Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Use soft alias as adaptercode #3467

Closed
wants to merge 4 commits into from
Closed

Fix: Use soft alias as adaptercode #3467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ea9eccc
Return corebidder as adaptercode in case of soft aliase
Pubmatic-Supriya-Patil Feb 6, 2024
6333f93
Return corebidder as adaptercode in case of soft aliase
Pubmatic-Supriya-Patil Feb 6, 2024
d97249d
Merge branch 'master' into Fix_3363_adaptercode
Pubmatic-Supriya-Patil Feb 6, 2024
bc9e630
Fix Gofmt
Pubmatic-Supriya-Patil Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions exchange/bidder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,6 +334,10 @@ func (bidder *bidderAdapter) requestBid(ctx context.Context, bidderRequest Bidde
if err == nil {
// Conversion rate found, using it for conversion
for i := 0; i < len(bidResponse.Bids); i++ {
if bidResponse.Bids[i].BidMeta == nil {
bidResponse.Bids[i].BidMeta = &openrtb_ext.ExtBidPrebidMeta{}
}
bidResponse.Bids[i].BidMeta.AdapterCode = bidderRequest.BidderName.String()

bidderName := bidderRequest.BidderName
if bidResponse.Bids[i].Seat != "" {
Expand Down
10 changes: 10 additions & 0 deletions exchange/bidder_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2522,6 +2522,7 @@ func TestExtraBid(t *testing.T) {
DealPriority: 5,
BidType: openrtb_ext.BidTypeVideo,
OriginalBidCur: "USD",
BidMeta: &openrtb_ext.ExtBidPrebidMeta{AdapterCode: string(openrtb_ext.BidderPubmatic)},
}},
Seat: "groupm",
Currency: "USD",
Expand All @@ -2533,6 +2534,7 @@ func TestExtraBid(t *testing.T) {
DealPriority: 4,
BidType: openrtb_ext.BidTypeBanner,
OriginalBidCur: "USD",
BidMeta: &openrtb_ext.ExtBidPrebidMeta{AdapterCode: string(openrtb_ext.BidderPubmatic)},
}},
Seat: string(openrtb_ext.BidderPubmatic),
Currency: "USD",
Expand Down Expand Up @@ -2630,6 +2632,7 @@ func TestExtraBidWithAlternateBidderCodeDisabled(t *testing.T) {
DealPriority: 5,
BidType: openrtb_ext.BidTypeVideo,
OriginalBidCur: "USD",
BidMeta: &openrtb_ext.ExtBidPrebidMeta{AdapterCode: string(openrtb_ext.BidderPubmatic)},
}},
Seat: "groupm-allowed",
Currency: "USD",
Expand All @@ -2641,6 +2644,7 @@ func TestExtraBidWithAlternateBidderCodeDisabled(t *testing.T) {
DealPriority: 4,
BidType: openrtb_ext.BidTypeBanner,
OriginalBidCur: "USD",
BidMeta: &openrtb_ext.ExtBidPrebidMeta{AdapterCode: string(openrtb_ext.BidderPubmatic)},
}},
Seat: string(openrtb_ext.BidderPubmatic),
Currency: "USD",
Expand Down Expand Up @@ -2738,6 +2742,7 @@ func TestExtraBidWithBidAdjustments(t *testing.T) {
BidType: openrtb_ext.BidTypeVideo,
OriginalBidCPM: 7,
OriginalBidCur: "USD",
BidMeta: &openrtb_ext.ExtBidPrebidMeta{AdapterCode: "PUBMATIC"},
}},
Seat: "groupm",
Currency: "USD",
Expand All @@ -2753,6 +2758,7 @@ func TestExtraBidWithBidAdjustments(t *testing.T) {
BidType: openrtb_ext.BidTypeBanner,
OriginalBidCur: "USD",
OriginalBidCPM: 3,
BidMeta: &openrtb_ext.ExtBidPrebidMeta{AdapterCode: "PUBMATIC"},
}},
Seat: "PUBMATIC",
Currency: "USD",
Expand Down Expand Up @@ -2851,6 +2857,7 @@ func TestExtraBidWithBidAdjustmentsUsingAdapterCode(t *testing.T) {
BidType: openrtb_ext.BidTypeVideo,
OriginalBidCPM: 7,
OriginalBidCur: "USD",
BidMeta: &openrtb_ext.ExtBidPrebidMeta{AdapterCode: string(openrtb_ext.BidderPubmatic)},
}},
Seat: "groupm",
Currency: "USD",
Expand All @@ -2866,6 +2873,7 @@ func TestExtraBidWithBidAdjustmentsUsingAdapterCode(t *testing.T) {
BidType: openrtb_ext.BidTypeBanner,
OriginalBidCur: "USD",
OriginalBidCPM: 3,
BidMeta: &openrtb_ext.ExtBidPrebidMeta{AdapterCode: string(openrtb_ext.BidderPubmatic)},
}},
Seat: string(openrtb_ext.BidderPubmatic),
Currency: "USD",
Expand Down Expand Up @@ -2963,6 +2971,7 @@ func TestExtraBidWithMultiCurrencies(t *testing.T) {
BidType: openrtb_ext.BidTypeVideo,
OriginalBidCPM: 7,
OriginalBidCur: "USD",
BidMeta: &openrtb_ext.ExtBidPrebidMeta{AdapterCode: string(openrtb_ext.BidderPubmatic)},
}},
Seat: "groupm",
Currency: "INR",
Expand All @@ -2978,6 +2987,7 @@ func TestExtraBidWithMultiCurrencies(t *testing.T) {
BidType: openrtb_ext.BidTypeBanner,
OriginalBidCPM: 3,
OriginalBidCur: "USD",
BidMeta: &openrtb_ext.ExtBidPrebidMeta{AdapterCode: string(openrtb_ext.BidderPubmatic)},
}},
Seat: string(openrtb_ext.BidderPubmatic),
Currency: "INR",
Expand Down
10 changes: 2 additions & 8 deletions exchange/exchange.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1282,7 +1282,7 @@ func (e *exchange) makeBid(bids []*entities.PbsOrtbBid, auc *auction, returnCrea
}
}

if bidExtJSON, err := makeBidExtJSON(bid.Bid.Ext, bidExtPrebid, impExtInfoMap, bid.Bid.ImpID, bid.OriginalBidCPM, bid.OriginalBidCur, adapter); err != nil {
if bidExtJSON, err := makeBidExtJSON(bid.Bid.Ext, bidExtPrebid, impExtInfoMap, bid.Bid.ImpID, bid.OriginalBidCPM, bid.OriginalBidCur); err != nil {
errs = append(errs, err)
} else {
result = append(result, *bid.Bid)
Expand All @@ -1296,7 +1296,7 @@ func (e *exchange) makeBid(bids []*entities.PbsOrtbBid, auc *auction, returnCrea
return result, errs
}

func makeBidExtJSON(ext json.RawMessage, prebid *openrtb_ext.ExtBidPrebid, impExtInfoMap map[string]ImpExtInfo, impId string, originalBidCpm float64, originalBidCur string, adapter openrtb_ext.BidderName) (json.RawMessage, error) {
func makeBidExtJSON(ext json.RawMessage, prebid *openrtb_ext.ExtBidPrebid, impExtInfoMap map[string]ImpExtInfo, impId string, originalBidCpm float64, originalBidCur string) (json.RawMessage, error) {
var extMap map[string]interface{}

if len(ext) != 0 {
Expand Down Expand Up @@ -1330,12 +1330,6 @@ func makeBidExtJSON(ext json.RawMessage, prebid *openrtb_ext.ExtBidPrebid, impEx
prebid.Meta = &metaContainer.Prebid.Meta
}

if prebid.Meta == nil {
prebid.Meta = &openrtb_ext.ExtBidPrebidMeta{}
}

prebid.Meta.AdapterCode = adapter.String()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it necessary to move this code out this function? Looks like the functional change is adapters can populate the AdapterCode and take priority.


// ext.prebid.storedrequestattributes and ext.prebid.passthrough
if impExtInfo, ok := impExtInfoMap[impId]; ok {
prebid.Passthrough = impExtInfoMap[impId].Passthrough
Expand Down
44 changes: 23 additions & 21 deletions exchange/exchange_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1631,7 +1631,7 @@ func TestBidResponseCurrency(t *testing.T) {
Price: 9.517803,
W: 300,
H: 250,
Ext: json.RawMessage(`{"origbidcpm":9.517803,"prebid":{"meta":{"adaptercode":"appnexus"},"type":"banner"}}`),
Ext: json.RawMessage(`{"origbidcpm":9.517803,"prebid":{"type":"banner"}}`),
},
},
},
Expand Down Expand Up @@ -1773,8 +1773,7 @@ func TestBidResponseImpExtInfo(t *testing.T) {
[]byte(`{"video":{"h":480,"mimes":["video/mp4"]}}`),
json.RawMessage(`{"imp_passthrough_val":1}`)}

expectedBidResponseExt := `{"origbidcpm":0,"prebid":{"meta":{"adaptercode":"appnexus"},"type":"video","passthrough":{"imp_passthrough_val":1}},"storedrequestattributes":{"h":480,"mimes":["video/mp4"]}}`

expectedBidResponseExt := `{"origbidcpm":0,"prebid":{"type":"video","passthrough":{"imp_passthrough_val":1}},"storedrequestattributes":{"h":480,"mimes":["video/mp4"]}}`
actualBidResp := e.buildBidResponse(context.Background(), liveAdapters, adapterBids, bidRequest, nil, nil, nil, true, impExtInfo, "", errList, &nonBids{})

resBidExt := string(actualBidResp.SeatBid[0].Bid[0].Ext)
Expand Down Expand Up @@ -3918,7 +3917,7 @@ func TestMakeBidExtJSON(t *testing.T) {
impExtInfo: map[string]ImpExtInfo{"test_imp_id": {true, []byte(`{"video":{"h":480,"mimes":["video/mp4"]}}`), json.RawMessage(`{"imp_passthrough_val": 1}`)}},
origbidcpm: 10.0000,
origbidcur: "USD",
expectedBidExt: `{"prebid":{"meta": {"brandName": "foo","adaptercode": "adapter"}, "passthrough":{"imp_passthrough_val":1}, "type":"video"}, "storedrequestattributes":{"h":480,"mimes":["video/mp4"]},"video":{"h":100}, "origbidcpm": 10, "origbidcur": "USD"}`,
expectedBidExt: `{"prebid":{"meta": {"brandName": "foo"}, "passthrough":{"imp_passthrough_val":1}, "type":"video"}, "storedrequestattributes":{"h":480,"mimes":["video/mp4"]},"video":{"h":100}, "origbidcpm": 10, "origbidcur": "USD"}`,
expectedErrMessage: "",
},
{
Expand All @@ -3928,7 +3927,7 @@ func TestMakeBidExtJSON(t *testing.T) {
impExtInfo: map[string]ImpExtInfo{"test_imp_id": {true, []byte(`{"video":{"h":480,"mimes":["video/mp4"]}}`), nil}},
origbidcpm: 10.0000,
origbidcur: "USD",
expectedBidExt: `{"prebid":{"meta": {"brandName": "foo","adaptercode": "adapter"}, "type":"video"},"storedrequestattributes":{"h":480,"mimes":["video/mp4"]},"video":{"h":100}, "origbidcpm": 10, "origbidcur": "USD"}`,
expectedBidExt: `{"prebid":{"meta": {"brandName": "foo"}, "type":"video"},"storedrequestattributes":{"h":480,"mimes":["video/mp4"]},"video":{"h":100}, "origbidcpm": 10, "origbidcur": "USD"}`,
expectedErrMessage: "",
},
{
Expand All @@ -3937,7 +3936,7 @@ func TestMakeBidExtJSON(t *testing.T) {
extBidPrebid: openrtb_ext.ExtBidPrebid{Type: openrtb_ext.BidType("video")},
impExtInfo: map[string]ImpExtInfo{"test_imp_id": {true, []byte(`{"video":{"h":480,"mimes":["video/mp4"]}}`), json.RawMessage(`{"imp_passthrough_val": 1}`)}},
origbidcpm: 0,
expectedBidExt: `{"origbidcpm": 0,"prebid":{"meta":{"adaptercode": "adapter"},"passthrough":{"imp_passthrough_val":1}, "type":"video"},"storedrequestattributes":{"h":480,"mimes":["video/mp4"]}}`,
expectedBidExt: `{"origbidcpm": 0,"prebid":{"passthrough":{"imp_passthrough_val":1}, "type":"video"},"storedrequestattributes":{"h":480,"mimes":["video/mp4"]}}`,
expectedErrMessage: "",
},
{
Expand All @@ -3947,7 +3946,7 @@ func TestMakeBidExtJSON(t *testing.T) {
impExtInfo: map[string]ImpExtInfo{"another_imp_id": {true, []byte(`{"video":{"h":480,"mimes":["video/mp4"]}}`), json.RawMessage(`{"imp_passthrough_val": 1}`)}},
origbidcpm: 10.0000,
origbidcur: "USD",
expectedBidExt: `{"prebid":{"meta":{"adaptercode": "adapter"},"type":"video"},"video":{"h":100}, "origbidcpm": 10, "origbidcur": "USD"}`,
expectedBidExt: `{"prebid":{"type":"video"},"video":{"h":100}, "origbidcpm": 10, "origbidcur": "USD"}`,
expectedErrMessage: "",
},
{
Expand All @@ -3957,7 +3956,7 @@ func TestMakeBidExtJSON(t *testing.T) {
origbidcpm: 10.0000,
origbidcur: "USD",
impExtInfo: map[string]ImpExtInfo{"test_imp_id": {true, []byte(`{"video":{"h":480,"mimes":["video/mp4"]}}`), json.RawMessage(`{"imp_passthrough_val": 1}`)}},
expectedBidExt: `{"prebid":{"meta":{"adaptercode": "adapter"},"passthrough":{"imp_passthrough_val":1}},"storedrequestattributes":{"h":480,"mimes":["video/mp4"]},"video":{"h":100}, "origbidcpm": 10, "origbidcur": "USD"}`,
expectedBidExt: `{"prebid":{"passthrough":{"imp_passthrough_val":1}},"storedrequestattributes":{"h":480,"mimes":["video/mp4"]},"video":{"h":100}, "origbidcpm": 10, "origbidcur": "USD"}`,
expectedErrMessage: "",
},
{
Expand All @@ -3967,7 +3966,7 @@ func TestMakeBidExtJSON(t *testing.T) {
origbidcpm: 10.0000,
origbidcur: "USD",
impExtInfo: nil,
expectedBidExt: `{"prebid":{"meta":{"adaptercode": "adapter"},"type":"video"},"video":{"h":100}, "origbidcpm": 10, "origbidcur": "USD"}`,
expectedBidExt: `{"prebid":{"type":"video"},"video":{"h":100}, "origbidcpm": 10, "origbidcur": "USD"}`,
expectedErrMessage: "",
},
{
Expand All @@ -3977,7 +3976,7 @@ func TestMakeBidExtJSON(t *testing.T) {
origbidcpm: 10.0000,
origbidcur: "USD",
impExtInfo: map[string]ImpExtInfo{"test_imp_id": {true, []byte(`{"banner":{"h":480}}`), json.RawMessage(`{"imp_passthrough_val": 1}`)}},
expectedBidExt: `{"prebid":{"meta":{"adaptercode": "adapter"},"passthrough":{"imp_passthrough_val":1}, "type":"video"},"video":{"h":100}, "origbidcpm": 10, "origbidcur": "USD"}`,
expectedBidExt: `{"prebid":{"passthrough":{"imp_passthrough_val":1}, "type":"video"},"video":{"h":100}, "origbidcpm": 10, "origbidcur": "USD"}`,
expectedErrMessage: "",
},
{
Expand All @@ -3987,7 +3986,7 @@ func TestMakeBidExtJSON(t *testing.T) {
origbidcpm: 10.0000,
origbidcur: "USD",
impExtInfo: map[string]ImpExtInfo{"test_imp_id": {true, []byte(`{"banner":{"h":480}}`), json.RawMessage(`{"imp_passthrough_val": 1}`)}},
expectedBidExt: `{"prebid":{"meta":{"adaptercode": "adapter"},"passthrough":{"imp_passthrough_val":1}, "type":"video"}, "origbidcpm": 10, "origbidcur": "USD"}`,
expectedBidExt: `{"prebid":{"passthrough":{"imp_passthrough_val":1}, "type":"video"}, "origbidcpm": 10, "origbidcur": "USD"}`,
expectedErrMessage: "",
},
{
Expand All @@ -3997,7 +3996,7 @@ func TestMakeBidExtJSON(t *testing.T) {
origbidcpm: 10.0000,
origbidcur: "USD",
impExtInfo: map[string]ImpExtInfo{"test_imp_id": {true, []byte(`{"video":{"h":480,"mimes":["video/mp4"]}}`), json.RawMessage(`{"imp_passthrough_val": 1}`)}},
expectedBidExt: `{"prebid":{"meta":{"adaptercode": "adapter"},"passthrough":{"imp_passthrough_val":1}, "type":"video"}, "storedrequestattributes":{"h":480,"mimes":["video/mp4"]}, "origbidcpm": 10, "origbidcur": "USD"}`,
expectedBidExt: `{"prebid":{"passthrough":{"imp_passthrough_val":1}, "type":"video"}, "storedrequestattributes":{"h":480,"mimes":["video/mp4"]}, "origbidcpm": 10, "origbidcur": "USD"}`,
expectedErrMessage: "",
},
{
Expand All @@ -4007,7 +4006,7 @@ func TestMakeBidExtJSON(t *testing.T) {
impExtInfo: map[string]ImpExtInfo{},
origbidcpm: 0,
origbidcur: "USD",
expectedBidExt: `{"origbidcpm": 0,"prebid":{"meta":{"brandName":"foo","adaptercode": "adapter"},"type":"banner"}, "origbidcur": "USD"}`,
expectedBidExt: `{"origbidcpm": 0,"prebid":{"meta":{"brandName":"foo"},"type":"banner"}, "origbidcur": "USD"}`,
expectedErrMessage: "",
},
{
Expand All @@ -4017,7 +4016,7 @@ func TestMakeBidExtJSON(t *testing.T) {
impExtInfo: nil,
origbidcpm: 0,
origbidcur: "USD",
expectedBidExt: `{"origbidcpm": 0,"prebid":{"meta":{"brandName":"foo","adaptercode": "adapter"},"type":"banner"}, "origbidcur": "USD"}`,
expectedBidExt: `{"origbidcpm": 0,"prebid":{"meta":{"brandName":"foo"},"type":"banner"}, "origbidcur": "USD"}`,
expectedErrMessage: "",
},
{
Expand All @@ -4027,7 +4026,7 @@ func TestMakeBidExtJSON(t *testing.T) {
impExtInfo: nil,
origbidcpm: 10.0000,
origbidcur: "USD",
expectedBidExt: `{"prebid":{"meta":{"brandName":"foo","adaptercode": "adapter"},"type":"banner"}, "origbidcpm": 10, "origbidcur": "USD"}`,
expectedBidExt: `{"prebid":{"meta":{"brandName":"foo"},"type":"banner"}, "origbidcpm": 10, "origbidcur": "USD"}`,
expectedErrMessage: "",
},
{
Expand All @@ -4037,7 +4036,7 @@ func TestMakeBidExtJSON(t *testing.T) {
impExtInfo: nil,
origbidcpm: 10.0000,
origbidcur: "USD",
expectedBidExt: `{"prebid":{"meta":{"brandName":"foo","adaptercode": "adapter"},"type":"banner"}, "origbidcpm": 10, "origbidcur": "USD"}`,
expectedBidExt: `{"prebid":{"meta":{"brandName":"foo"},"type":"banner"}, "origbidcpm": 10, "origbidcur": "USD"}`,
expectedErrMessage: "",
},
{
Expand All @@ -4047,7 +4046,7 @@ func TestMakeBidExtJSON(t *testing.T) {
impExtInfo: nil,
origbidcpm: -1,
origbidcur: "USD",
expectedBidExt: `{"prebid":{"meta":{"brandName":"foo","adaptercode":"adapter"},"type":"banner"}, "origbidcur": "USD"}`,
expectedBidExt: `{"prebid":{"meta":{"brandName":"foo"},"type":"banner"}, "origbidcur": "USD"}`,
expectedErrMessage: "",
},
{
Expand All @@ -4057,7 +4056,7 @@ func TestMakeBidExtJSON(t *testing.T) {
impExtInfo: nil,
origbidcpm: 0,
origbidcur: "USD",
expectedBidExt: `{"origbidcpm": 0,"prebid":{"type":"banner","meta":{"adaptercode":"adapter"}}, "origbidcur": "USD"}`,
expectedBidExt: `{"origbidcpm": 0,"prebid":{"type":"banner"}, "origbidcur": "USD"}`,
expectedErrMessage: "",
},
//Error cases
Expand All @@ -4079,8 +4078,7 @@ func TestMakeBidExtJSON(t *testing.T) {

for _, test := range testCases {
t.Run(test.description, func(t *testing.T) {
var adapter openrtb_ext.BidderName = "adapter"
result, err := makeBidExtJSON(test.ext, &test.extBidPrebid, test.impExtInfo, "test_imp_id", test.origbidcpm, test.origbidcur, adapter)
result, err := makeBidExtJSON(test.ext, &test.extBidPrebid, test.impExtInfo, "test_imp_id", test.origbidcpm, test.origbidcur)

if test.expectedErrMessage == "" {
assert.JSONEq(t, test.expectedBidExt, string(result), "Incorrect result")
Expand Down Expand Up @@ -4124,7 +4122,7 @@ func TestStoredAuctionResponses(t *testing.T) {
SeatBid: []openrtb2.SeatBid{
{
Bid: []openrtb2.Bid{
{ID: "bid_id", ImpID: "impression-id", Ext: json.RawMessage(`{"origbidcpm":0,"prebid":{"meta":{"adaptercode":"appnexus"},"type":"video"}}`)},
{ID: "bid_id", ImpID: "impression-id", Ext: json.RawMessage(`{"origbidcpm":0,"prebid":{"type":"video"}}`)},
},
Seat: "appnexus",
},
Expand Down Expand Up @@ -5171,6 +5169,7 @@ func TestGetAllBids(t *testing.T) {
ID: "1",
},
OriginalBidCur: "USD",
BidMeta: &openrtb_ext.ExtBidPrebidMeta{AdapterCode: string(openrtb_ext.BidderPubmatic)},
},
},
Currency: "USD",
Expand Down Expand Up @@ -5239,6 +5238,7 @@ func TestGetAllBids(t *testing.T) {
ID: "1",
},
OriginalBidCur: "USD",
BidMeta: &openrtb_ext.ExtBidPrebidMeta{AdapterCode: string(openrtb_ext.BidderPubmatic)},
},
},
Currency: "USD",
Expand All @@ -5252,6 +5252,7 @@ func TestGetAllBids(t *testing.T) {
ID: "2",
},
OriginalBidCur: "USD",
BidMeta: &openrtb_ext.ExtBidPrebidMeta{AdapterCode: string(openrtb_ext.BidderPubmatic)},
},
},
Currency: "USD",
Expand Down Expand Up @@ -5319,6 +5320,7 @@ func TestGetAllBids(t *testing.T) {
ID: "2",
},
OriginalBidCur: "USD",
BidMeta: &openrtb_ext.ExtBidPrebidMeta{AdapterCode: string(openrtb_ext.BidderPubmatic)},
},
},
Currency: "USD",
Expand Down
4 changes: 2 additions & 2 deletions exchange/exchangetest/alternate-bidder-codes.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@
"origbidcpm": 0.51,
"prebid": {
"meta": {
"adaptercode": "groupm"
"adaptercode": "pubmatic"
},
"type": "video"
}
Expand All @@ -220,7 +220,7 @@
"origbidcpm": 0.3,
"prebid": {
"meta": {
"adaptercode": "groupm"
"adaptercode": "appnexus"
},
"type": "banner"
}
Expand Down
6 changes: 0 additions & 6 deletions exchange/exchangetest/append-bidder-names.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,9 +137,6 @@
"origbidcpm": 0.3,
"prebid": {
"type": "video",
"meta": {
"adaptercode":"appnexus"
},
"targeting": {
"hb_bidder": "appnexus",
"hb_bidder_appnexus": "appnexus",
Expand All @@ -165,9 +162,6 @@
"ext": {
"origbidcpm": 0.6,
"prebid": {
"meta": {
"adaptercode":"appnexus"
},
"targeting": {
"hb_bidder": "appnexus",
"hb_bidder_appnexus": "appnexus",
Expand Down
9 changes: 0 additions & 9 deletions exchange/exchangetest/bid-consolidation-test.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,9 +127,6 @@
"ext": {
"origbidcpm": 0.4,
"prebid": {
"meta": {
"adaptercode":"rubicon"
},
"type": "video"
}
}
Expand All @@ -149,9 +146,6 @@
"ext": {
"origbidcpm": 0.3,
"prebid": {
"meta": {
"adaptercode":"appnexus"
},
"type": "video"
}
}
Expand All @@ -166,9 +160,6 @@
"ext": {
"origbidcpm": 0.6,
"prebid": {
"meta": {
"adaptercode":"appnexus"
},
"type": "video"
}
}
Expand Down
Loading
Loading