Adot: add new bid param publisherPath #2164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#6) * [SUPPORT-4219] feature: add publisher path to endpoint from ext.bidder
AlexBVolcy
reviewed
Feb 23, 2022
| @@ -46,9 +47,17 @@ func (a *adapter) MakeRequests(request *openrtb2.BidRequest, reqInfo *adapters.E | |||
| headers := http.Header{} | |||
| headers.Add("Content-Type", "application/json;charset=utf-8") | |||
|
|
|||
| if adotExt := getImpAdotExt(&request.Imp[0]); adotExt != nil { | |||
There was a problem hiding this comment.
For my understanding, could there be a situation where request.Imp has multiple entries, and you'd want the publisher path from an entry other than request.Imp[0]?
There was a problem hiding this comment.
The publisher path will be used with some of our partners for custom integrations, so the value should be the same across all request.Imp entries
AlexBVolcy
approved these changes
Feb 28, 2022
pm-nilesh-chate
pushed a commit
to PubMatic-OpenWrap/prebid-server
that referenced
this pull request
Mar 30, 2022
jorgeluisrocha
pushed a commit
to jwplayer/prebid-server
that referenced
this pull request
Sep 28, 2022
shunj-nb
pushed a commit
to ParticleMedia/prebid-server
that referenced
this pull request
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR is about adding a new bid param
placementPathto our adapter.We also updated our doc in this PR
Best regards,