Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I am building a Bidder. Do I need to build a legacy Adapter? #340

Closed
muncha opened this issue Feb 12, 2018 · 1 comment
Closed

I am building a Bidder. Do I need to build a legacy Adapter? #340

muncha opened this issue Feb 12, 2018 · 1 comment

Comments

@muncha
Copy link
Contributor

muncha commented Feb 12, 2018

I am working on a Bidder for Beachfront Media (beachfront.com). I'm following the documentation here. I still need to work on my test cases and a few other things, but, it is working with our endpoint using a POST request similar to what is described here.

My next stage of testing has been to run prebid.js on a test page and have it send requests as described here. I'm sending those to openrtb2/auction/, but I get an "id undefined" error. Testing with appnexus instead, it appears to work, but I notice in the example it is using /auction/. Researching that has led me to the legacy docs page. I only implemented a Bidder, not the Call() method for an Adapter, as the comments at the top of legacy.go (previously adapter.go) specifically say not to.

The instructions on the legacy Adapter docs say "If you need live server-side support ... you can also follow the steps described on this page." So that sounds like I should implement both in my beachfront.go.

Before I get into that though, I just wanted to check, should I build an Adapter, or is there some other option?

@dbemiller
Copy link
Contributor

Nah. In fact I'd prefer it if you didn't, because it's less code to review & maintain. Prebid.js is adding finishing touches to the PBS adapter, so any legacy code you add will have a very short lifespan.

If you really need legacy support because you can't wait for that PR, or have important publishers can't or won't update to the latest Prebid.js, I'd much rather see a (Bidder, familyName, usersyncInfo, ???) => Adapter function which back-ports OpenRTB bidders into Legacy ones. Basically the inverse of this, but for maintaining legacy support of new Bidders.

StarWindMoonCloud pushed a commit to ParticleMedia/prebid-server that referenced this issue Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants