New adapter: Connektai - Xeworks alias #3730 #3738
Conversation
| adapters: | ||
| connektai: | ||
| endpoint: http://rtb.connektai.live/?pid={{.SourceId}}&host={{.Host}}&s=pbs | ||
| aliases: | ||
| xeworks: | ||
| meta-info: | ||
| maintainer-email: adops@connekt.ai | ||
| app-media-types: | ||
| - banner | ||
| - video | ||
| - native | ||
| site-media-types: | ||
| - banner | ||
| - video | ||
| - native | ||
| supported-vendors: | ||
| vendor-id: 0 | ||
| usersync: | ||
| cookie-family-name: xeworks | ||
| redirect: |
There was a problem hiding this comment.
this config won't work, please make it properly + add the integration test for the new alias
P.S. the placeholders won't work as well
| @@ -500,6 +500,8 @@ adapters.vrtcal.enabled=true | |||
| adapters.vrtcal.endpoint=http://localhost:8090/vrtcal-exchange | |||
| adapters.xeworks.enabled=true | |||
| adapters.xeworks.endpoint=http://localhost:8090/xeworks-exchange | |||
| adapters.xeworks.aliases.connektai.enabled=true | |||
| adapters.xeworks.aliases.connektai.endpoint=http://localhost:8090/connektai-exchange?host={{Host}}&sourceId={{SourceId}} | |||
There was a problem hiding this comment.
I added params because:
| .withQueryParam("host", equalTo("envValue")) | ||
| .withQueryParam("sourceId", equalTo("pidValue")) |
There was a problem hiding this comment.
There is no need to test this. It is already tested in the unit tests for the base bidder. We write integration tests only to check that the configurations are correct and that the simplest request will pass from request to response.
There was a problem hiding this comment.
I added this because @AntoxaAntoxic said to do it.
Okey, I understand. So where should I check if, for example, in a YAML file, we have two fields, but only one is required, such as placementId? Should I write the tests here?
🔧 Type of changes
✨ What's the context?
#3730