Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Uids Cookies Support #3668

Merged
merged 12 commits into from
Jan 29, 2025
Merged

Multiple Uids Cookies Support #3668

merged 12 commits into from
Jan 29, 2025

Conversation

AntoxaAntoxic
Copy link
Collaborator

🔧 Type of changes

  • new bid adapter
  • bid adapter update
  • new feature
  • new analytics adapter
  • new module
  • module update
  • bugfix
  • documentation
  • configuration
  • dependency update
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

prebid/prebid-server#4080

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🔎 New Bid Adapter Checklist

  • verify email contact works
  • NO fully dynamic hostnames
  • geographic host parameters are NOT required
  • direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@AntoxaAntoxic AntoxaAntoxic self-assigned this Jan 9, 2025
@osulzhenko
Copy link
Collaborator

please resolve conflicts

@osulzhenko osulzhenko requested review from CTMBNara and And1sS January 20, 2025 10:57
@AntoxaAntoxic AntoxaAntoxic requested a review from And1sS January 24, 2025 15:27
And1sS
And1sS previously approved these changes Jan 27, 2025
* Tests: Multiple Uids Cookies Support
@osulzhenko osulzhenko requested a review from CTMBNara January 28, 2025 20:18
marki1an
marki1an previously approved these changes Jan 29, 2025
@CTMBNara CTMBNara merged commit 171a19b into master Jan 29, 2025
7 checks passed
@CTMBNara CTMBNara deleted the multiple-uids-cookies branch January 29, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants