Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix InternalTestApp building #982

Merged
merged 2 commits into from
May 22, 2024
Merged

Fix InternalTestApp building #982

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02692e0
fix: InternalTestApp building
OlenaPostindustria May 21, 2024
1fcd005
feat: support GMA SDK 11.5.0
OlenaPostindustria May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion EventHandlers/PrebidMobileAdMobAdapters/Sources/PrebidAdMobMediationBaseAdapter.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ public class PrebidAdMobMediationBaseAdapter: NSObject, GADMediationAdapter {

// Added for tests
static func latestTestedGMAVersion() -> GADVersionNumber {
return GADVersionNumber(majorVersion: 11, minorVersion: 3, patchVersion: 0)
return GADVersionNumber(majorVersion: 11, minorVersion: 5, patchVersion: 0)
}

required public override init() {
Expand Down
2 changes: 1 addition & 1 deletion EventHandlers/PrebidMobileGAMEventHandlers/Sources/GAMUtils.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ public class GAMUtils: NSObject {

// Added for tests
static func latestTestedGMAVersion() -> GADVersionNumber {
return GADVersionNumber(majorVersion: 11, minorVersion: 3, patchVersion: 0)
return GADVersionNumber(majorVersion: 11, minorVersion: 5, patchVersion: 0)
}

// MARK: Private Methods
Expand Down
10 changes: 5 additions & 5 deletions InternalTestApp/PrebidMobileDemoRendering/AppDelegate.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,11 +141,11 @@ class AppDelegate: UIResponder, UIApplicationDelegate {

AdMobUtils.initializeGAD()

ALSdk.shared()?.mediationProvider = "max"
ALSdk.shared()?.userIdentifier = "USER_ID"
ALSdk.shared()?.initializeSdk { (configuration: ALSdkConfiguration) in
Log.info(String(describing: ALSdk.shared()?.isInitialized))
}
let config = ALSdkInitializationConfiguration(
sdkKey: "1tLUnP4cVQqpHuHH2yMtfdESvvUhTB05NdbCoDTceDDNVnhd_T8kwIzXDN9iwbdULTboByF-TtNaiTmsoVbxZw"
)

ALSdk.shared().initialize(with: config)

// Prebid Rendering Configs
Prebid.shared.logLevel = .info
Expand Down
2 changes: 1 addition & 1 deletion InternalTestApp/PrebidMobileDemoRendering/ViewControllers/AboutViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ class AboutViewController : FormViewController {
"OMSDK_Prebidorg": Prebid.shared.omsdkVersion
]),
("Ad Server SDKs", [
"GoogleMobileAds SDK": GADMobileAds.sharedInstance().sdkVersion,
"GoogleMobileAds SDK": "\(GADMobileAds.sharedInstance().versionNumber)",
]),
("Bridging SDKs", [
"GAM Event Handlers": versionOfBundle(providing: GAMBannerEventHandler.self),
Expand Down
16 changes: 8 additions & 8 deletions Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
PODS:
- Alamofire (4.9.1)
- AppLovinSDK (12.4.1)
- AppLovinSDK (12.5.0)
- Eureka (5.4.0)
- Google-Mobile-Ads-SDK (11.3.0):
- Google-Mobile-Ads-SDK (11.5.0):
- GoogleUserMessagingPlatform (>= 1.1)
- GoogleAds-IMA-iOS-SDK (3.22.1)
- GoogleUserMessagingPlatform (2.3.0)
- RxSwift (6.6.0)
- GoogleUserMessagingPlatform (2.4.0)
- RxSwift (6.7.1)
- SVProgressHUD (2.3.1):
- SVProgressHUD/Core (= 2.3.1)
- SVProgressHUD/Core (2.3.1)
Expand All @@ -33,12 +33,12 @@ SPEC REPOS:

SPEC CHECKSUMS:
Alamofire: 85e8a02c69d6020a0d734f6054870d7ecb75cf18
AppLovinSDK: c57ad0d34625c971d2db127f8ef60570b28ff51a
AppLovinSDK: 626d2aea57ae1bf9280d2012e8e20c521c58ce28
Eureka: fadaa9fa3d6e402d3c60f78f24edf3d7bafc9c29
Google-Mobile-Ads-SDK: 301a16c461c331ba34ff4dab40a22ab7c147af61
Google-Mobile-Ads-SDK: 7db2098033ad3bfcd72a11e7503b49700a93029e
GoogleAds-IMA-iOS-SDK: 160c3616b8371b58016e30aaf441e71d6d9e8f7d
GoogleUserMessagingPlatform: b1ad7bb1ee3ce64749d4fec24f667b36e45c396c
RxSwift: a4b44f7d24599f674deebd1818eab82e58410632
GoogleUserMessagingPlatform: f131fa7978d2ba88d7426702b057c2cc318e6595
RxSwift: b9a93a26031785159e11abd40d1a55bcb8057e52
SVProgressHUD: 4837c74bdfe2e51e8821c397825996a8d7de6e22

PODFILE CHECKSUM: bae4436ed691a1d2217fde386d8881d6e7e06963
Expand Down
2 changes: 1 addition & 1 deletion PrebidMobile/ConfigurationAndTargeting/PrebidGAMVersionChecker.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import Foundation
class PrebidGAMVersionChecker {

var latestTestedGMAVersion: (Int, Int, Int) {
(11, 3, 0)
(11, 5, 0)
}

var currentGMAVersion: (Int, Int, Int)?
Expand Down