Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement third-party tracker when clicked - Link.ClickTrackers #885

Merged
merged 7 commits into from
Jul 27, 2023
Merged

Implement third-party tracker when clicked - Link.ClickTrackers #885

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4dccaa2
Added clickTracker to click events.
jsligh Jul 25, 2023
f2fc92b
Merge branch 'master' into third_party_link_click_trackers
jsligh Jul 26, 2023
4b464c0
Merge branch 'master' into third_party_link_click_trackers
jsligh Jul 27, 2023
27a21d7
change click trackers to fire once click URL is successfully opened, …
jsligh Jul 27, 2023
ed98a68
Added clickTracker to click events.
jsligh Jul 25, 2023
2778641
change click trackers to fire once click URL is successfully opened, …
jsligh Jul 27, 2023
8d7de05
Merge branch 'third_party_link_click_trackers' of https://github.com/…
jsligh Jul 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion PrebidMobile/AdUnits/Native/NativeAd.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,12 +292,25 @@ import UIKit
if let clickUrl = nativeAdMarkup?.link?.url,
let clickUrlString = clickUrl.addingPercentEncoding(withAllowedCharacters: .urlQueryAllowed),
let url = URL(string: clickUrlString) {
if !openURLWithExternalBrowser(url: url) {
if openURLWithExternalBrowser(url: url) {
if let clickTrackers = nativeAdMarkup?.link?.clicktrackers {
fireClickTrackers(clickTrackersUrls: clickTrackers)
}
} else {
Log.debug("Could not open click URL: \(clickUrl)")
}
}
}


private func fireClickTrackers(clickTrackersUrls: [String]) {
if clickTrackersUrls.count > 0 {
TrackerManager.shared.fireTrackerURLArray(arrayWithURLs: clickTrackersUrls) {
_ in
}
}
}

private func openURLWithExternalBrowser(url : URL) -> Bool {
if UIApplication.shared.canOpenURL(url) {
UIApplication.shared.open(url, options: [:], completionHandler: nil)
Expand Down
5 changes: 3 additions & 2 deletions PrebidMobileTests/TrackerManagerTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,9 @@ class TrackerManagerTests: XCTestCase {

func testTrackerManagerWithFireTrackerURL() {
firedImpressionTrackerExpectation = expectation(description: "\(#function)")
let urlString = "https://acdn.adnxs.com/mobile/native_test/empty_response.json"
TrackerManager.shared.fireTrackerURLArray(arrayWithURLs: [urlString]) { [weak self] (isTrackerURLFired) in
let impressionString = "https://acdn.adnxs.com/mobile/native_test/empty_response.json"
let clickTrackerString = "https://testUrl.com/events/click/root/url"
TrackerManager.shared.fireTrackerURLArray(arrayWithURLs: [impressionString, clickTrackerString]) { [weak self] (isTrackerURLFired) in
if isTrackerURLFired{
self?.firedImpressionTrackerExpectation?.fulfill()
}
Expand Down