External User IDs Improvements #1092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuriyVelichkoPI
requested changes
Jan 28, 2025
| return StorageUtils.getExternalUserIds() | ||
| /// This method allows to get all External User Ids | ||
| @available(*, deprecated, message: "Deprecated. SDK doesn't support storing External User IDs in application storage. This method will be removed in future releases.") | ||
| public func fetchStoredExternalUserIds() -> [ExternalUserId]? { |
There was a problem hiding this comment.
The method storeExternalUserId should be also deprecated.
| arrayExternalUserIds.removeAll() | ||
| StorageUtils.setExternalUserIds(value: arrayExternalUserIds) | ||
| } | ||
| externalUserIds = [] | ||
| } | ||
|
|
||
| public func getExternalUserIds() -> [[AnyHashable: Any]]? { |
There was a problem hiding this comment.
There are a lot of changes in the PR, so I can miss something, but now I see incosistency in how external ids can be set and retirived.
I see two public items:
- the property
externalUserIds - the method
getExternalUserIds
And the method has broader functionality. To make everything consistent, I'd suggest making externalUserIds private and to add the setExternalUserIds method. Or you can introduce a custom getter for externalUserIds.
|
@OlenaPostindustria, please, rebase the branch. |
bdd0fab to
8392cb5
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1091