-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate PrebidMobile Documentation #1034
Conversation
69653a3
to
a9a2754
Compare
7cabbda
to
609bf41
Compare
cd3be8b
to
630602e
Compare
Thanks for checking the docs_new directory size. Does this generate docs on every commit, on merge to master, or on release? I would think that on-release is what we'd want. I propose that we merge this when happy, then wait for a release to happen to test the update script before placing the links around docs.prebid.org. |
Documentation generation starts when a tag is pushed(f.e., 1.0.0), so it happens on release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My review was limited to the workflow script. My take is this can be released when ready. We're not going to link to the results until after the next SDK release after confirming the release did the right thing to the documentation repo.
thanks!
Closes #990
API reference is here: https://docs.prebid.org/prebid-mobile-ios/index.html