Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PubMatic to execute tracker pixel in iframe. #937

Merged
merged 10 commits into from
Feb 1, 2017
Merged

PubMatic to execute tracker pixel in iframe. #937

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7e7b622
PubMatic: passing pageurl in postbid
pm-harshad-mane Dec 22, 2016
dda4db6
removed code committed accidently in master
pm-harshad-mane Jan 10, 2017
172b2a1
Removed code accidently commited to master
pm-harshad-mane Jan 10, 2017
c292dbc
Merge https://github.com/prebid/Prebid.js
pm-harshad-mane Jan 10, 2017
15210c8
new function createTrackPixelIframeHtml in util
pm-harshad-mane Jan 11, 2017
640b3d1
minor fix in return statement of createTrackPixelIframeHtml
pm-harshad-mane Jan 11, 2017
b3b3cb5
PubMatic to execute impression tracker in iframe
pm-harshad-mane Jan 19, 2017
6e1647c
Merge https://github.com/prebid/Prebid.js
pm-harshad-mane Jan 19, 2017
a288f87
PubMatic to execute tracker pixel in iframe.
pm-harshad-mane Jan 19, 2017
7195aa4
utils.createTrackPixelIframeHtml: using string template literals
pm-harshad-mane Feb 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/adapters/pubmatic.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ var PubmaticAdapter = function PubmaticAdapter() {
adResponse.adSlot = bid.adSlot;
adResponse.cpm = Number(adUnitInfo.bid);
adResponse.ad = unescape(adUnit.creative_tag); // jshint ignore:line
adResponse.ad += utils.createTrackPixelHtml(decodeURIComponent(adUnit.tracking_url));
adResponse.ad += utils.createTrackPixelIframeHtml(decodeURIComponent(adUnit.tracking_url));
adResponse.width = dimensions[0];
adResponse.height = dimensions[1];
adResponse.dealId = adUnitInfo.wdeal;
Expand Down
13 changes: 13 additions & 0 deletions src/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,6 +470,19 @@ exports.createTrackPixelHtml = function (url) {
return img;
};

/**
* Creates a snippet of Iframe HTML that retrieves the specified `url`
* @param {string} url plain URL to be requested
* @return {string} HTML snippet that contains the iframe src = set to `url`
*/
exports.createTrackPixelIframeHtml = function (url) {
if (!url) {
return '';
}

return `<iframe frameborder="0" allowtransparency="true" marginheight="0" marginwidth="0" width="0" hspace="0" vspace="0" height="0" style="height:0p;width:0p;display:none;" scrolling="no" src="${encodeURI(url)}"></iframe>`;
};

/**
* Returns iframe document in a browser agnostic way
* @param {object} iframe reference
Expand Down