rewrite groupByPlacement to avoid multiple scans of array #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch also uses more descriptive argument names.
lines 53 and 61 - allows the http response from our ad api to set cookies. This somehow increases fill. everything else - fixes an issue where "no bid" responses aren't registered with prebid in certain cases, causing auction timeouts.
|
sorry I bungled the pull request, it's only supposed to be commit 897d34f. Should I resubmit the PR on its own branch? Thanks. |
|
No worries, the extra commits will be squashed |
matthewlane
approved these changes
Feb 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
I noticed groupByPlacement had a few unnecessary loops and not very descriptive variable names, so I cleaned it up a bit.