Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Browserstack tests into Travis CI build #839

Merged
merged 1 commit into from
Feb 9, 2017

Conversation

matthewlane
Copy link
Collaborator

@matthewlane matthewlane commented Nov 29, 2016

Type of change

  • CI related changes

Description of change

This configures Travis to run unit tests on Browserstack. This PR sets Chrome 56 on Mac 10.12 (Travis natively uses Chrome 37 on Ubunut). In the future we may set additional browsers to run.

Other information

Resolves #766

@matthewlane matthewlane force-pushed the browserstack-travis branch 2 times, most recently from bcf3df5 to 48e981d Compare December 1, 2016 19:47
@protonate protonate self-assigned this Dec 12, 2016
@protonate protonate self-requested a review December 12, 2016 20:22
.travis.yml Outdated
addons:
browserstack:
username:
secure: "JzUfrZKE8iIuutyiz1AMoQHe1hCgj4nq0CXWHTAoPCUbEZ0duXYt8NbOpQtkDT91C0TnCUoiMeLHJioyiA4EQm6PWTNBp/tzoD5i1vhGZ+iFhwS0eOMLx/OdGKOwddbWZVdcfRoUvv0TF5Wb15Q7goodstwVjnErNuZ0BMYdQnCEF9zduH3CJHa91LDWLWrrLz/oKUyQIwewcZ51bBs2EAnvt91mhOO2elvU6v5PtgKlS8IV7QTG2pXBLOIOHbbWr73lyse8E/lz41Gk3Tp8VG43pQ7syz+n+1rmnljlA1k3jEQPazJix1dxdfN6xIm/ur6k0mqWa1clRKTg2YVwItyXUIwsS2+fmOngow+NKzsYNtTwv7tSSD03VUZL2o1ydefEQBN9p8gk9rQdp+CMoR1LpzM8J1eIdRO419FpZyzPblDhJgfujC5O3h3Z/k4Cz+h+/8sx1Ms5rWN5/qJyTzQCFI6NK2MAgC1IO+nZmPJ/8sr6cJVltUBNqHbyuFE5bSnQdm/Ljpda2MMa8A+BCf5/qyATMHp/Gm5i7lyM/b3a2n1FRJQNjB2tRwSJpj5BJMr30F3Hz+6d+2/+lFHF2vMNF5S0WYbirl3nvu8JGf0s1YGoK67cYlSLsWmCp+PE2OwTTMS/EA30TOFKNs7XEnxwZAVd5Y2MjzUAOmiX25A="
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this sensitive data? Should we pull from local env var?

@matthewlane matthewlane force-pushed the browserstack-travis branch 5 times, most recently from ceb89a9 to 9110056 Compare February 8, 2017 00:28
@mkendall07
Copy link
Member

LGTM.

@mkendall07 mkendall07 merged commit 7cbe60b into master Feb 9, 2017
@matthewlane matthewlane deleted the browserstack-travis branch February 9, 2017 18:22
mp-12301 pushed a commit to aol/Prebid.js that referenced this pull request Apr 10, 2017
…ebid-official-0.19.0 to release/1.14.0

* commit 'b13f7ba7ee8b3c168dc0af7c8bfc94747d017e70': (34 commits)
  Add changelog entry.
  Prebid 0.19.0 Release
  check truthiness of adUnitCode (prebid#990)
  fixed exception when refreshing individual Ad Units and bidder responds slowly (prebid#989)
  Stub pixel drop to prevent network request in test (prebid#988)
  Updating Komoona adapter to support future Prebid requirements (prebid#974)
  Use stable version of Chrome (prebid#984)
  Revert to running browser tests in Travis (prebid#983)
  Fix issue with appnexusAst sending `user` object in the wrong place. (prebid#980)
  Integrate Browserstack tests into Travis CI build (prebid#839)
  Add StickyAdsTV Bidder adapter (prebid#916)
  Stronger xdomain checks (prebid#971)
  added matomy as an alias for appnexus (prebid#850)
  Added 152Media Appnexus Alias (prebid#952)
  OpenX Adapter: Handles fallback ads correctly as a no fill (prebid#39) (prebid#963)
  Use package dependencies for ES6 Array shims (prebid#962)
  Make x-domain safe frame example work out of the box (prebid#955)
  added usersync for adkernel adapter (prebid#951)
  Rubicon adapter: add a floor variable (prebid#964)
  Added Lifestreet adapter. (prebid#965)
  ...
mp-12301 pushed a commit to aol/Prebid.js that referenced this pull request Apr 10, 2017
…14.0 to master

* commit 'c008f3f531ae3409f4a16bf03470d84e82aead0e': (35 commits)
  Add adapters in aolPartnersIds.json.
  Add changelog entry.
  Prebid 0.19.0 Release
  check truthiness of adUnitCode (prebid#990)
  fixed exception when refreshing individual Ad Units and bidder responds slowly (prebid#989)
  Stub pixel drop to prevent network request in test (prebid#988)
  Updating Komoona adapter to support future Prebid requirements (prebid#974)
  Use stable version of Chrome (prebid#984)
  Revert to running browser tests in Travis (prebid#983)
  Fix issue with appnexusAst sending `user` object in the wrong place. (prebid#980)
  Integrate Browserstack tests into Travis CI build (prebid#839)
  Add StickyAdsTV Bidder adapter (prebid#916)
  Stronger xdomain checks (prebid#971)
  added matomy as an alias for appnexus (prebid#850)
  Added 152Media Appnexus Alias (prebid#952)
  OpenX Adapter: Handles fallback ads correctly as a no fill (prebid#39) (prebid#963)
  Use package dependencies for ES6 Array shims (prebid#962)
  Make x-domain safe frame example work out of the box (prebid#955)
  added usersync for adkernel adapter (prebid#951)
  Rubicon adapter: add a floor variable (prebid#964)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants