Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adtelligent Bid Adapter: add JANet adapter alias #8102

Merged
merged 6 commits into from
Apr 7, 2022

Conversation

GeneGenie
Copy link
Contributor

Type of change

  • New bidder adapter

Description of change

add new bid adapter for JANnet

  • test parameters for validating bids
{
  bidder: 'janet',
  params: {
    aid: 472386
  }
}

@ChrisHuie ChrisHuie changed the title add JANet adapter Adtelligent Bid Adapter: add JANet adapter alias Feb 24, 2022
@ChrisHuie ChrisHuie self-requested a review February 24, 2022 12:29
@ChrisHuie ChrisHuie self-assigned this Feb 24, 2022
@ChrisHuie
Copy link
Collaborator

@GeneGenie can you please take out the package-lock file 🙏

@patmmccann
Copy link
Collaborator

patmmccann commented Mar 9, 2022

These alias deletions might break some people; could you differentiate the adds from the deletes in a different pr

@GeneGenie
Copy link
Contributor Author

These alias deletions might break some people; could you differentiate the adds from the deletes in a different pr

Repushed

@GeneGenie
Copy link
Contributor Author

Hi @ChrisHuie can we move with this PR ?
thanks

modules/adtelligentBidAdapter.js Outdated Show resolved Hide resolved
@patmmccann
Copy link
Collaborator

@GeneGenie please note the linting error

@GeneGenie GeneGenie requested a review from patmmccann March 28, 2022 08:59
@GeneGenie
Copy link
Contributor Author

@patmmccann hi, can we merge this ?

@GeneGenie
Copy link
Contributor Author

Hi, @ChrisHuie, please tell me we can move on with this ;)

@sunnylapin
Copy link

@ChrisHuie @patmmccann Hello Gentleman, could you please let me know whether we would be able to see this merged in this weeks release?

@ChrisHuie
Copy link
Collaborator

@GeneGenie @sunnylapin this looks good to me except the testing changes to prebidServer Bid adapter. Those changes in this pr do not look intended?

@GeneGenie
Copy link
Contributor Author

There was a change from master that added MediaFuse as a standalone adapter, and test related to hadcoded MediaFuse antialias alias.
Test has broken since MF became a separate adapter, and now test covers antiAlias feature without requiring any adapters' implementation

@ChrisHuie ChrisHuie merged commit 301c0aa into prebid:master Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants