Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build to only run webpack to improve build time performance #809

Merged
merged 1 commit into from
Nov 29, 2016

Conversation

mkendall07
Copy link
Member

Type of change

  • Build related changes

Description of change

Currently, gulp build runs essentially the same sub-tasks as gulp serve - which is intended for development.

I purpose to make gulp build to be for production builds only, which drops all the other unnecessary tasks, and greatly speeds build time. This is for the download page efficiency.

Slightly breaking change, as this no longer builds /build/dev/* resources.

Other information

@prebid/core for review

Copy link
Collaborator

@matthewlane matthewlane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

@mkendall07 mkendall07 merged commit 5f5e941 into master Nov 29, 2016
@mkendall07 mkendall07 deleted the feature/build_faster branch November 29, 2016 20:09
mp-12301 pushed a commit to aol/Prebid.js that referenced this pull request Apr 10, 2017
…ebid-official-0.16.0 to release/1.10.0

* commit 'fd16420d7034b1f82e571e2b122b7fa73b88d929':
  Add changelog entry.
  Add new adapters for AOL analytics.
  Updated Prebid version
  Catch cross-origin DOMException (prebid#861)
  Add GumGum adapter (prebid#833)
  Remove duplicate log line in request bids (prebid#859)
  Utility function getBidIdParamater is misspelled
  Allow Conversant sizes to be overridden per placement (prebid#816)
  Add districtmDMX adapter (prebid#811)
  Truncate bids requested on clearPlacements (prebid#825) (prebid#828)
  Update adapters.json (prebid#803)
  Add usersyncing to AppNexus adapters (prebid#845)
  fixes for bugs in test suite (prebid#810)
  Pass user object parameters on bid request (prebid#821)
  fix rubicon deals to be per ad instead of per response (prebid#838)
  Links bidId in request with adId in response for analytics purposes (prebid#836)
  Bugfix/issue building from npm (prebid#823)
  Update build to only run `webpack` to improve build time performance (prebid#809)
  Cast all Conversant site_ids to a string (prebid#829)
  Increment pre version
mp-12301 pushed a commit to aol/Prebid.js that referenced this pull request Apr 10, 2017
…10.0 to master

* commit 'b39f2b12a8ddfa650a8e04e3abd358e60371950a':
  Add changelog entry.
  Add new adapters for AOL analytics.
  Updated Prebid version
  Catch cross-origin DOMException (prebid#861)
  Add GumGum adapter (prebid#833)
  Remove duplicate log line in request bids (prebid#859)
  Utility function getBidIdParamater is misspelled
  Allow Conversant sizes to be overridden per placement (prebid#816)
  Add districtmDMX adapter (prebid#811)
  Truncate bids requested on clearPlacements (prebid#825) (prebid#828)
  Update adapters.json (prebid#803)
  Add usersyncing to AppNexus adapters (prebid#845)
  fixes for bugs in test suite (prebid#810)
  Pass user object parameters on bid request (prebid#821)
  fix rubicon deals to be per ad instead of per response (prebid#838)
  Links bidId in request with adId in response for analytics purposes (prebid#836)
  Bugfix/issue building from npm (prebid#823)
  Update build to only run `webpack` to improve build time performance (prebid#809)
  Cast all Conversant site_ids to a string (prebid#829)
  Increment pre version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants