modify mediago bidder adapter to compatible with version 2.0 and version 3.0 #5680

SylviaF · 2020-08-31T12:30:10Z

Type of change

Bugfix
Feature
New bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other

Description of change

modify mediago bidder adapter to compatible with version 2.0 and version 3.0

test parameters for validating bids

{
  bidder: 'mediago',
  params: {
          token: '85a6b01e41ac36d49744fad726e3655d'
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

contact email of the adapter’s maintainer
official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

A link to a PR on the docs repo at https://github.com/prebid/prebid.github.io/

Other information

patmmccann · 2020-08-31T18:14:03Z

modules/mediagoBidAdapter.js

+ */
+const getCookie = function(name) {
+  if (getProperty(window, 'document', 'cookie')) {
+    let m = window.document.cookie.match('(^|;)\\s*' + name + '\\s*=\\s*([^;]*)\\s*(;|$)');


why did you comment out and bypass storage manager?

I need to compatible with Prebid v2.0 and v3.0.
And the storage manager dosen't be added in v2.0 and v3.0.

patmmccann · 2020-09-01T01:29:24Z

The 3.27.x legacy branch will not have any more merges

SylviaF · 2020-09-01T12:07:25Z

The 3.27.x legacy branch will not have any more merges

Hi, sorry for the trouble.

Because our partners are unwilling to use the new version, if the old version cannot be merged into the new update, I would like to know what other way we can cooperate with those partners who do not want to use the new version Prebid?

patmmccann · 2020-09-01T12:40:06Z

Perhaps your partners' concerns can be addressed? What are they?

…

On Tue, Sep 1, 2020, 8:07 AM 方思敏 ***@***.***> wrote: The 3.27.x legacy branch will not have any more merges Hi, sorry for the trouble. Because our partners are unwilling to use the new version, if the old version cannot be merged into the new update, I would like to know what other way we can cooperate with those partners who do not want to use the new version Prebid? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#5680 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAM25Z6R2OTGHEMJBYAKVSDSDTPYZANCNFSM4QQO2A4A> .

SylviaF · 2020-09-02T01:21:31Z

Perhaps your partners' concerns can be addressed? What are they?
…
On Tue, Sep 1, 2020, 8:07 AM 方思敏 @.***> wrote: The 3.27.x legacy branch will not have any more merges Hi, sorry for the trouble. Because our partners are unwilling to use the new version, if the old version cannot be merged into the new update, I would like to know what other way we can cooperate with those partners who do not want to use the new version Prebid? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#5680 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAM25Z6R2OTGHEMJBYAKVSDSDTPYZANCNFSM4QQO2A4A .

Not all SSP partners have the latest adapter; updating to the latest prebid breaks functionality for some partners, different wrapper partners only support certain adapter versions

patmmccann · 2020-09-02T13:43:14Z

If functionality is breaking on a recent version, I'd encourage you to open an issue. However, your adapter needs to follow rules that are built with publisher trust in mind. One of these is using the storage manager.

SylviaF · 2020-09-03T02:06:34Z

If functionality is breaking on a recent version, I'd encourage you to open an issue. However, your adapter needs to follow rules that are built with publisher trust in mind. One of these is using the storage manager.

If it is not merged into the master, but only added to the old version branch, For example, is it allowed if I only change the code and merge some specific branches, such as v3.2.

patmmccann · 2020-09-03T15:20:22Z

We don't do merges to old branches except near the time of major version releases. 3.27.1 was the last 3.x release and there are no more planned.

patmmccann · 2020-09-03T15:21:01Z

Also, your PR is against master and not against legacy anyways

SylviaF · 2020-09-04T03:48:30Z

We don't do merges to old branches except near the time of major version releases. 3.27.1 was the last 3.x release and there are no more planned.

OK, sorry for the trouble and thanks for your answer. I think this PR can be dropped now.

But I found that our mediago bid adapter seems to be released in version 4.5.
I would like to know if there is a chance to update to at least to version 4.0 - version 4.5?

patmmccann · 2020-09-04T13:49:28Z

You're welcome to submit changes to your adapter against the master branch. There are not separate branches for each minor version change that you can commit against and that are maintained independently. If you make commits now, your existing adapter would be in 4.5 and your changes would likely be in 4.7 or 4.8. The version that is in 4.5 now will never change. Every week the number increments, with any change to 4.x

…

On Thu, Sep 3, 2020 at 11:48 PM 方思敏 ***@***.***> wrote: We don't do merges to old branches except near the time of major version releases. 3.27.1 was the last 3.x release and there are no more planned. OK, sorry for the trouble and thanks for your answer. I think this PR can be dropped now. But I found that our mediago bid adapter seems to be released in version 4.5. I would like to know if there is a chance to update to at least to version 4.0 - version 4.5? — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#5680 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAM25Z634YLESU4RWJ357YTSEBPR5ANCNFSM4QQO2A4A> .

SylviaF · 2020-09-07T01:48:18Z

You're welcome to submit changes to your adapter against the master branch. There are not separate branches for each minor version change that you can commit against and that are maintained independently. If you make commits now, your existing adapter would be in 4.5 and your changes would likely be in 4.7 or 4.8. The version that is in 4.5 now will never change. Every week the number increments, with any change to 4.x
…
On Thu, Sep 3, 2020 at 11:48 PM 方思敏 @.***> wrote: We don't do merges to old branches except near the time of major version releases. 3.27.1 was the last 3.x release and there are no more planned. OK, sorry for the trouble and thanks for your answer. I think this PR can be dropped now. But I found that our mediago bid adapter seems to be released in version 4.5. I would like to know if there is a chance to update to at least to version 4.0 - version 4.5? — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#5680 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAM25Z634YLESU4RWJ357YTSEBPR5ANCNFSM4QQO2A4A .

Got it. Thanks for your patience and answer.

stale · 2020-10-04T02:47:35Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

SylviaF and others added 10 commits August 12, 2020 20:23

mediago bid adaptor

a441c1e

修改去掉固定ip

3abeb76

mediago bid adapter: add test spec

5aecdb8

spec code style

dc364b1

change into prod EP and auto size.

efe765f

delete other param

674a6c9

修改为强制https协议

5c9fb22

Merge remote-tracking branch 'upstream/master'

4bb7fd4

compatible to v2.0 and v3.0

814de25

change code style

eb8fa8d

patmmccann reviewed Aug 31, 2020

View reviewed changes

More than 1 blank line

7f22279

fangsimin@baidu.com added 2 commits September 1, 2020 10:05

More than 1 blank line

63dcf2d

Merge branch 'master' of https://github.com/SylviaF/Prebid.js

49d8d79

jaiminpanchal27 assigned patmmccann Sep 2, 2020

fangsimin@baidu.com added 2 commits September 3, 2020 20:07

Merge remote-tracking branch 'upstream/master'

63aec0c

Merge branch 'master' of https://github.com/SylviaF/Prebid.js

7a6f7dd

smenzer mentioned this pull request Sep 8, 2020

add new version for DecenterAds #5711

Merged

10 tasks

stale bot added the stale label Oct 4, 2020

stale bot closed this Oct 11, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

modify mediago bidder adapter to compatible with version 2.0 and version 3.0 #5680

modify mediago bidder adapter to compatible with version 2.0 and version 3.0 #5680

SylviaF commented Aug 31, 2020

patmmccann Aug 31, 2020

SylviaF Sep 1, 2020

patmmccann commented Sep 1, 2020 •

edited

Loading

SylviaF commented Sep 1, 2020

patmmccann commented Sep 1, 2020 via email

SylviaF commented Sep 2, 2020

patmmccann commented Sep 2, 2020 •

edited

Loading

SylviaF commented Sep 3, 2020

patmmccann commented Sep 3, 2020

patmmccann commented Sep 3, 2020

SylviaF commented Sep 4, 2020

patmmccann commented Sep 4, 2020 via email

SylviaF commented Sep 7, 2020

stale bot commented Oct 4, 2020

modify mediago bidder adapter to compatible with version 2.0 and version 3.0 #5680

modify mediago bidder adapter to compatible with version 2.0 and version 3.0 #5680

Conversation

SylviaF commented Aug 31, 2020

Type of change

Description of change

Other information

patmmccann Aug 31, 2020

Choose a reason for hiding this comment

SylviaF Sep 1, 2020

Choose a reason for hiding this comment

patmmccann commented Sep 1, 2020 • edited Loading

SylviaF commented Sep 1, 2020

patmmccann commented Sep 1, 2020 via email

SylviaF commented Sep 2, 2020

patmmccann commented Sep 2, 2020 • edited Loading

SylviaF commented Sep 3, 2020

patmmccann commented Sep 3, 2020

patmmccann commented Sep 3, 2020

SylviaF commented Sep 4, 2020

patmmccann commented Sep 4, 2020 via email

SylviaF commented Sep 7, 2020

stale bot commented Oct 4, 2020

patmmccann commented Sep 1, 2020 •

edited

Loading

patmmccann commented Sep 2, 2020 •

edited

Loading