parrableIdSystem: Relocate new unit test from upstream

modules/parrableIdSystem.js

@@ -102,12 +102,14 @@ function readLegacyCookies() {
 }
 
 function migrateLegacyCookies(parrableId) {
-  writeCookie(parrableId);
-  if (parrableId.eid) {
-    storage.setCookie(LEGACY_ID_COOKIE_NAME, '', EXPIRE_COOKIE_DATE);
-  }
-  if (parrableId.ibaOptout) {
-    storage.setCookie(LEGACY_OPTOUT_COOKIE_NAME, '', EXPIRE_COOKIE_DATE);
+  if (parrableId) {
+    writeCookie(parrableId);
+    if (parrableId.eid) {
+      storage.setCookie(LEGACY_ID_COOKIE_NAME, '', EXPIRE_COOKIE_DATE);
+    }
+    if (parrableId.ibaOptout) {
+      storage.setCookie(LEGACY_OPTOUT_COOKIE_NAME, '', EXPIRE_COOKIE_DATE);
+    }
   }
 }
 
@@ -161,10 +163,11 @@ function fetchId(configParams) {
                 parrableId.ibaOptout = true;
               }
               writeCookie(responseObj);
+              cb(parrableId);
             }
           } catch (error) {
             utils.logError(error);
-            cb(eid);
+            cb();
           }
         }
       },

test/spec/modules/parrableIdSystem_spec.js

@@ -75,15 +75,18 @@ function removeParrableCookie() {
 
 describe('Parrable ID System', function() {
   describe('parrableIdSystem.getId() callback', function() {
+    let logErrorStub;
     let callbackSpy = sinon.spy();
 
     beforeEach(function() {
+      logErrorStub = sinon.stub(utils, 'logError');
       callbackSpy.resetHistory();
       writeParrableCookie({ eid: P_COOKIE_EID });
     });
 
     afterEach(function() {
       removeParrableCookie();
+      logErrorStub.restore();
     })
 
     it('creates xhr to Parrable that synchronizes the ID', function() {
@@ -130,6 +133,21 @@ describe('Parrable ID System', function() {
       uspDataHandler.setConsentData(null);
       expect(server.requests[0].url).to.contain('us_privacy=' + uspString);
     });
+
+    it('should log an error and continue to callback if ajax request errors', function () {
+      let callBackSpy = sinon.spy();
+      let submoduleCallback = parrableIdSubmodule.getId({partner: 'prebid'}).callback;
+      submoduleCallback(callBackSpy);
+      let request = server.requests[0];
+      expect(request.url).to.contain('h.parrable.com');
+      request.respond(
+        503,
+        null,
+        'Unavailable'
+      );
+      expect(logErrorStub.calledOnce).to.be.true;
+      expect(callBackSpy.calledOnce).to.be.true;
+    });
   });
 
   describe('parrableIdSystem.getId() id', function() {
@@ -182,21 +200,18 @@ describe('Parrable ID System', function() {
 
   describe('userId requestBids hook', function() {
     let adUnits;
-    let logErrorStub;
 
     beforeEach(function() {
       adUnits = [getAdUnitMock()];
       writeParrableCookie({ eid: P_COOKIE_EID });
       setSubmoduleRegistry([parrableIdSubmodule]);
       init(config);
       config.setConfig(getConfigMock());
-      logErrorStub = sinon.stub(utils, 'logError');
     });
 
     afterEach(function() {
       removeParrableCookie();
       storage.setCookie(P_COOKIE_NAME, '', EXPIRED_COOKIE_DATE);
-      logErrorStub.restore();
     });
 
     it('when a stored Parrable ID exists it is added to bids', function(done) {
@@ -210,20 +225,5 @@ describe('Parrable ID System', function() {
         done();
       }, { adUnits });
     });
-
-    it('should log an error and continue to callback if ajax request errors', function () {
-      let callBackSpy = sinon.spy();
-      let submoduleCallback = parrableIdSubmodule.getId({partner: 'prebid'}).callback;
-      submoduleCallback(callBackSpy);
-      let request = server.requests[0];
-      expect(request.url).to.contain('h.parrable.com');
-      request.respond(
-        503,
-        null,
-        'Unavailable'
-      );
-      expect(logErrorStub.calledOnce).to.be.true;
-      expect(callBackSpy.calledOnce).to.be.true;
-    });
   });
 });