GumGum: uses encodeURIComponent inline #5124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jsnellbaker @harpere , Is it possible to get this reviewed and released quickly? the release today (3.16.0) causes curly braces to be left in our query string which we'd like to avoid thanks! |
|
Hi @susyt - sounds like a test may be needed around this parameter. |
harpere
requested changes
Apr 16, 2020
|
Thank you for getting back to me so quickly! yes, I apologize for asking but my team/manager has asked if it were possible to get it released sooner |
harpere
approved these changes
Apr 17, 2020
|
merged, but we rarely do early releases, and even then only to fix core problems, not adapters. |
redaguermas
added a commit
to redaguermas/Prebid.js
that referenced
this pull request
Apr 20, 2020
* 'master' of https://github.com/prebid/Prebid.js: Revert "New LuponMedia Bid Adapter (prebid#5120)" (prebid#5145) New LuponMedia Bid Adapter (prebid#5120) Feature/send publisher domain (prebid#5121) update test adunit params (prebid#5135) add parameter to the conversant adapter to override the url (prebid#5133) Replace call to old url module with call to utils (prebid#5136) GumGum: uses encodeURIComponent inline (prebid#5124) User ID's (liveramp, britepool) and gdpr (prebid#5114) fix wipes adapter response (prebid#5134) Submitting Tercept Analytics Adapter (prebid#5099) hotfix - undefined consent (prebid#5127) parrableIdSystem: Send current page location to back-end (prebid#5123) Increment pre version Prebid 3.16.0 Release Use a deepmerge function to merge both globa level config & bidder specific config (prebid#5039) Update appnexusBidAdapter.js (prebid#4893) Quantcast: Block bids without purpose 1 consent (prebid#5046) ShowHeroes adapter v2 (prebid#5085) Qc/qc usersyncs (prebid#4923)
redaguermas
added a commit
to redaguermas/Prebid.js
that referenced
this pull request
Apr 20, 2020
* master: Revert "New LuponMedia Bid Adapter (prebid#5120)" (prebid#5145) New LuponMedia Bid Adapter (prebid#5120) Feature/send publisher domain (prebid#5121) update test adunit params (prebid#5135) add parameter to the conversant adapter to override the url (prebid#5133) Replace call to old url module with call to utils (prebid#5136) GumGum: uses encodeURIComponent inline (prebid#5124) User ID's (liveramp, britepool) and gdpr (prebid#5114) fix wipes adapter response (prebid#5134) Submitting Tercept Analytics Adapter (prebid#5099) hotfix - undefined consent (prebid#5127) parrableIdSystem: Send current page location to back-end (prebid#5123) Increment pre version Prebid 3.16.0 Release Use a deepmerge function to merge both globa level config & bidder specific config (prebid#5039) Update appnexusBidAdapter.js (prebid#4893) Quantcast: Block bids without purpose 1 consent (prebid#5046) ShowHeroes adapter v2 (prebid#5085) Qc/qc usersyncs (prebid#4923)
iggyfisk
pushed a commit
to happypancake/Prebid.js
that referenced
this pull request
Jun 22, 2020
* uses encodeURIComponent inline * adds test for jcsi param
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Encodes a param object instead of relying on parseQueryStringParameters