Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Valueimpression Bid Adapter #4974

Merged
merged 5 commits into from
Mar 21, 2020
Merged

Add Valueimpression Bid Adapter #4974

merged 5 commits into from
Mar 21, 2020

Conversation

thuyhq
Copy link
Contributor

@thuyhq thuyhq commented Mar 13, 2020

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Add new bid adapter for Valueimpression

  • test parameters for validating bids
    Banner Test Parameters
var adUnits = [
  {
    code: 'test-div',
    mediaTypes: {
      banner: {
        sizes: [[300, 250], [300,600]]
      }
    },
    bids: [
      {
          bidder: 'valueimpression',
          params: {
              siteId: 'vi-site-id',
          }
      }
    ]
  }
];

Video Test Parameters

var videoAdUnit = [{
  code: 'test-div',
  sizes: [[640, 480]],
  mediaTypes: {
    video: {
      playerSize: [[640, 480]],
      context: 'instream'
    },
  },
  bids: [
    {
      bidder: 'valueimpression',
      params: {
        siteId: 'vi-site-id',
      }
    }
  ]
}];

@mike-chowla mike-chowla self-requested a review March 17, 2020 21:23
@mike-chowla mike-chowla self-assigned this Mar 17, 2020
Copy link
Contributor

@mike-chowla mike-chowla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mike-chowla mike-chowla merged commit 9523787 into prebid:master Mar 21, 2020
jimee02 pushed a commit to openx/Prebid.js that referenced this pull request Mar 25, 2020
* Add Valueimpression Bid Adapter

* Update valueimpressionBidAdapter_spec.js

* Update valueimpressionBidAdapter.md

* Lint valueimpressionBidAdapter.js

* Update valueimpressionBidAdapter.js
bmwcmw pushed a commit to criteo-forks/Prebid.js that referenced this pull request Mar 31, 2020
* Add Valueimpression Bid Adapter

* Update valueimpressionBidAdapter_spec.js

* Update valueimpressionBidAdapter.md

* Lint valueimpressionBidAdapter.js

* Update valueimpressionBidAdapter.js
rjvelicaria pushed a commit to openx/Prebid.js that referenced this pull request Apr 9, 2020
* Add Valueimpression Bid Adapter

* Update valueimpressionBidAdapter_spec.js

* Update valueimpressionBidAdapter.md

* Lint valueimpressionBidAdapter.js

* Update valueimpressionBidAdapter.js
iggyfisk pushed a commit to happypancake/Prebid.js that referenced this pull request Jun 22, 2020
* Add Valueimpression Bid Adapter

* Update valueimpressionBidAdapter_spec.js

* Update valueimpressionBidAdapter.md

* Lint valueimpressionBidAdapter.js

* Update valueimpressionBidAdapter.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants