Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update consent manager to support a new config prop: defaultGdprScope #4970

Merged
merged 67 commits into from
Mar 24, 2020
Merged

update consent manager to support a new config prop: defaultGdprScope #4970

merged 67 commits into from
Mar 24, 2020

Conversation

idettman
Copy link
Contributor

@idettman idettman commented Mar 13, 2020 •
edited
Loading

Type of change

  • Feature

Description of change

Related Issue: 4747

Rubicon (and perhaps other bidders?) is not always doing IP address lookups to determine GDPR scope. So if the CMP doesn't load and an EU request goes out without the "&gdpr=1" flag, a cookie may be set.
Prebid.js could solve this problem allowing pubs to force the page into GDPR mode.

Proposal:

pbjs.setConfig({
    consentManagement: {
          gdpr: {
              cmpApi: 'iab',
              timeout: 8000,
              allowAuctionWithoutConsent: false,
              defaultGdprScope: true         // use defaultGdprScope for gdprApplies if it was not defined
            }
      }
});

Other information

#4747

nakamoto and others added 30 commits February 16, 2019 21:30
Add microadBidAdapter
8d635ff
Remove unnecessary encodeURIComponent from microadBidAdapter
3055b90
Submit Advangelists Prebid Adapter
67fb91b
Submit Advangelists Prebid Adapter 1.1
3ebb916
Correct procudtion endpoint for prebid
4f5c451
Merge branch 'microad-bid-adapter' of git://github.com/strong-zero/Pr…
2dc6d1d 
…ebid.js into master-rubicon-clean
Merge remote-tracking branch 'origin/master' into master-rubicon-clean
fa3e081 
# Conflicts:
#	modules/advangelistsBidAdapter.js
#	test/spec/modules/advangelistsBidAdapter_spec.js
Merge branch 'master' of https://github.com/prebid/Prebid.js into mas…
600a46e 
…ter-remote-updated
Merge branch 'master' of https://github.com/prebid/Prebid.js
7f578b3
Merge branch 'master' of https://github.com/prebid/Prebid.js
176a312
Merge branch 'master' of https://github.com/prebid/Prebid.js
9abf89c
Merge remote-tracking branch 'upstream/master'
6ce04ab
Merge branch 'master' of https://github.com/prebid/Prebid.js into mas…
415e2f6 
…ter-origin
Merge branch 'master' of https://github.com/prebid/Prebid.js into mas…
61fb82c 
…ter-origin-rp
analytics update with wrapper name
3cc4c67
Merge branch 'master' of https://github.com/prebid/Prebid.js into mas…
cd81e02 
…ter-origin-rp
Merge branch 'master' of https://github.com/prebid/Prebid.js into mas…
e2b4e04 
…ter-origin-rp
Merge branch 'master' of https://github.com/prebid/Prebid.js into mas…
53b5970 
…ter-origin-rp
Merge branch 'master' of https://github.com/prebid/Prebid.js into mas…
5c00ed5 
…ter-origin-rp
reverted error merge
28848ad
Merge branch 'master' of https://github.com/prebid/Prebid.js into mas…
ab635ee 
…ter-origin-rp
Merge branch 'master' of https://github.com/prebid/Prebid.js into mas…
93308f5 
…ter-origin-rp
Merge branch 'master' of https://github.com/prebid/Prebid.js
1cfd52d
Merge branch 'master' of https://github.com/prebid/Prebid.js
d619807
Merge branch 'master' of https://github.com/prebid/Prebid.js
9893f0f
Merge remote-tracking branch 'upstream/master'
986a251
Merge branch 'master' of https://github.com/prebid/Prebid.js into ori…
2cae7c0 
…gin-master
Merge branch 'master' of https://github.com/prebid/Prebid.js
d7fd252
Merge branch 'master' of https://github.com/prebid/Prebid.js
c7c01ba
Merge branch 'master' of https://github.com/prebid/Prebid.js
24a28aa
@idettman idettman requested a review from harpere March 13, 2020 01:25
@idettman idettman added needs 2nd review Core module updates require two approvals from the core team needs review labels Mar 13, 2020
@bretg bretg requested a review from jsnellbaker March 13, 2020 14:49
@bretg
Copy link
Collaborator

bretg commented Mar 13, 2020

covered by docs PR prebid/prebid.github.io#1857

@bretg bretg removed the request for review from jsnellbaker March 13, 2020 14:57
@bretg
Copy link
Collaborator

bretg commented Mar 13, 2020

Sorry - I muddied things here with the original post. The intention was that the defaultGdprScope flag was indeed a default - if gdprApplies is specified by the CMP, we should use that. The scenario this fixes is when there's no CMP response.

bretg
bretg requested changes Mar 13, 2020
View reviewed changes
modules/consentManagement.js Outdated Show resolved Hide resolved
@idettman idettman requested review from bretg and jsnellbaker March 23, 2020 17:31
jsnellbaker
jsnellbaker reviewed Mar 24, 2020
View reviewed changes
Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, had one clarifying question though. See below when possible.

Thanks!

modules/consentManagement.js Show resolved Hide resolved
@bretg bretg removed needs 2nd review Core module updates require two approvals from the core team needs review labels Mar 24, 2020
@bretg bretg merged commit f0bc358 into prebid:master Mar 24, 2020
@bretg
Copy link
Collaborator

bretg commented Mar 24, 2020

docs PR prebid/prebid.github.io#1880

jimee02 pushed a commit to openx/Prebid.js that referenced this pull request Mar 25, 2020
@msm0504
update consent manager to support a new config prop: defaultGdprScope (…
24993be 
…prebid#4970)

* Add microadBidAdapter

* Remove unnecessary encodeURIComponent from microadBidAdapter

* Submit Advangelists Prebid Adapter

* Submit Advangelists Prebid Adapter 1.1

* Correct procudtion endpoint for prebid

* analytics update with wrapper name

* reverted error merge

* update changed default value of netRevenue to true

* Re-add rubicon analytics without deprecated getTopWindowUrl util

* Cache referrer on auction_init instead of bid_requested

* add gdprScope config support

* add tests

* updated with requested changes from the pull request

* optimization to simplify setting the gdprApplies value

Co-authored-by: nakamoto <nakamoto_tatsuya@microad.co.jp>
Co-authored-by: Chandra Prakash <chandra.prakash@advangelists.com>
Co-authored-by: Eric Harper <eharper@rubiconproject.com>
Co-authored-by: TJ Eastmond <teastmond@la-wlandaverde-mac.local>
Co-authored-by: Mark Monday <mmonday@rubiconproject.com>
Co-authored-by: msm0504 <51493331+msm0504@users.noreply.github.com>
rjvelicaria pushed a commit to openx/Prebid.js that referenced this pull request Apr 9, 2020
@msm0504 @rjvelicaria
update consent manager to support a new config prop: defaultGdprScope (…
41cb1ae 
…prebid#4970)

* Add microadBidAdapter

* Remove unnecessary encodeURIComponent from microadBidAdapter

* Submit Advangelists Prebid Adapter

* Submit Advangelists Prebid Adapter 1.1

* Correct procudtion endpoint for prebid

* analytics update with wrapper name

* reverted error merge

* update changed default value of netRevenue to true

* Re-add rubicon analytics without deprecated getTopWindowUrl util

* Cache referrer on auction_init instead of bid_requested

* add gdprScope config support

* add tests

* updated with requested changes from the pull request

* optimization to simplify setting the gdprApplies value

Co-authored-by: nakamoto <nakamoto_tatsuya@microad.co.jp>
Co-authored-by: Chandra Prakash <chandra.prakash@advangelists.com>
Co-authored-by: Eric Harper <eharper@rubiconproject.com>
Co-authored-by: TJ Eastmond <teastmond@la-wlandaverde-mac.local>
Co-authored-by: Mark Monday <mmonday@rubiconproject.com>
Co-authored-by: msm0504 <51493331+msm0504@users.noreply.github.com>
iggyfisk pushed a commit to happypancake/Prebid.js that referenced this pull request Jun 22, 2020
@msm0504 @iggyfisk
update consent manager to support a new config prop: defaultGdprScope (…
517c27f 
…prebid#4970)

* Add microadBidAdapter

* Remove unnecessary encodeURIComponent from microadBidAdapter

* Submit Advangelists Prebid Adapter

* Submit Advangelists Prebid Adapter 1.1

* Correct procudtion endpoint for prebid

* analytics update with wrapper name

* reverted error merge

* update changed default value of netRevenue to true

* Re-add rubicon analytics without deprecated getTopWindowUrl util

* Cache referrer on auction_init instead of bid_requested

* add gdprScope config support

* add tests

* updated with requested changes from the pull request

* optimization to simplify setting the gdprApplies value

Co-authored-by: nakamoto <nakamoto_tatsuya@microad.co.jp>
Co-authored-by: Chandra Prakash <chandra.prakash@advangelists.com>
Co-authored-by: Eric Harper <eharper@rubiconproject.com>
Co-authored-by: TJ Eastmond <teastmond@la-wlandaverde-mac.local>
Co-authored-by: Mark Monday <mmonday@rubiconproject.com>
Co-authored-by: msm0504 <51493331+msm0504@users.noreply.github.com>
@robertrmartinez robertrmartinez deleted the consent-manager-force-gdpr-mode branch July 5, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bretg bretg bretg approved these changes

@harpere harpere harpere approved these changes

@jsnellbaker jsnellbaker jsnellbaker approved these changes

Assignees

@harpere harpere

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@idettman @bretg @harpere @jsnellbaker @msm0504