-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
appnexus adapter : include hb_source in request to server #4964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@sumit116 Looks good. Please add unit tests |
jaiminpanchal27
approved these changes
Mar 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jimee02
pushed a commit
to openx/Prebid.js
that referenced
this pull request
Mar 25, 2020
* appnexus adapter : include hb_source in request to server * add unit tests * Revert "add unit tests" This reverts commit 7b6f97c. * Revert "appnexus adapter : include hb_source in request to server" This reverts commit 2a24271. * move hb_source to tag level * update if condition for adpod Co-authored-by: sumit sharma <sumit.sharma1@SYNPUNLT9114TFL.SYNAPPNXS.local> Co-authored-by: sumit sharma <sumit.sharma1@SYNPUNLT9114TFL.appnexus.com>
bmwcmw
pushed a commit
to criteo-forks/Prebid.js
that referenced
this pull request
Mar 31, 2020
* appnexus adapter : include hb_source in request to server * add unit tests * Revert "add unit tests" This reverts commit 7b6f97c. * Revert "appnexus adapter : include hb_source in request to server" This reverts commit 2a24271. * move hb_source to tag level * update if condition for adpod Co-authored-by: sumit sharma <sumit.sharma1@SYNPUNLT9114TFL.SYNAPPNXS.local> Co-authored-by: sumit sharma <sumit.sharma1@SYNPUNLT9114TFL.appnexus.com>
rjvelicaria
pushed a commit
to openx/Prebid.js
that referenced
this pull request
Apr 9, 2020
* appnexus adapter : include hb_source in request to server * add unit tests * Revert "add unit tests" This reverts commit 7b6f97c. * Revert "appnexus adapter : include hb_source in request to server" This reverts commit 2a24271. * move hb_source to tag level * update if condition for adpod Co-authored-by: sumit sharma <sumit.sharma1@SYNPUNLT9114TFL.SYNAPPNXS.local> Co-authored-by: sumit sharma <sumit.sharma1@SYNPUNLT9114TFL.appnexus.com>
iggyfisk
pushed a commit
to happypancake/Prebid.js
that referenced
this pull request
Jun 22, 2020
* appnexus adapter : include hb_source in request to server * add unit tests * Revert "add unit tests" This reverts commit 7b6f97c. * Revert "appnexus adapter : include hb_source in request to server" This reverts commit 2a24271. * move hb_source to tag level * update if condition for adpod Co-authored-by: sumit sharma <sumit.sharma1@SYNPUNLT9114TFL.SYNAPPNXS.local> Co-authored-by: sumit sharma <sumit.sharma1@SYNPUNLT9114TFL.appnexus.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Add a param to inform appnexus adapter endpoint whether the request is an adpod request or any other media type.
Other information