Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appnexus adapter : include hb_source in request to server #4964

Merged
merged 6 commits into from
Mar 24, 2020

Conversation

sumit116
Copy link
Contributor

@sumit116 sumit116 commented Mar 11, 2020

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Add a param to inform appnexus adapter endpoint whether the request is an adpod request or any other media type.

Other information

@jaiminpanchal27
Copy link
Collaborator

@sumit116 Looks good. Please add unit tests

Copy link
Collaborator

@jaiminpanchal27 jaiminpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sumit116 sumit116 merged commit 07cf06f into master Mar 24, 2020
jimee02 pushed a commit to openx/Prebid.js that referenced this pull request Mar 25, 2020
* appnexus adapter : include hb_source in request to server

* add unit tests

* Revert "add unit tests"

This reverts commit 7b6f97c.

* Revert "appnexus adapter : include hb_source in request to server"

This reverts commit 2a24271.

* move hb_source to tag level

* update if condition for adpod

Co-authored-by: sumit sharma <sumit.sharma1@SYNPUNLT9114TFL.SYNAPPNXS.local>
Co-authored-by: sumit sharma <sumit.sharma1@SYNPUNLT9114TFL.appnexus.com>
bmwcmw pushed a commit to criteo-forks/Prebid.js that referenced this pull request Mar 31, 2020
* appnexus adapter : include hb_source in request to server

* add unit tests

* Revert "add unit tests"

This reverts commit 7b6f97c.

* Revert "appnexus adapter : include hb_source in request to server"

This reverts commit 2a24271.

* move hb_source to tag level

* update if condition for adpod

Co-authored-by: sumit sharma <sumit.sharma1@SYNPUNLT9114TFL.SYNAPPNXS.local>
Co-authored-by: sumit sharma <sumit.sharma1@SYNPUNLT9114TFL.appnexus.com>
rjvelicaria pushed a commit to openx/Prebid.js that referenced this pull request Apr 9, 2020
* appnexus adapter : include hb_source in request to server

* add unit tests

* Revert "add unit tests"

This reverts commit 7b6f97c.

* Revert "appnexus adapter : include hb_source in request to server"

This reverts commit 2a24271.

* move hb_source to tag level

* update if condition for adpod

Co-authored-by: sumit sharma <sumit.sharma1@SYNPUNLT9114TFL.SYNAPPNXS.local>
Co-authored-by: sumit sharma <sumit.sharma1@SYNPUNLT9114TFL.appnexus.com>
iggyfisk pushed a commit to happypancake/Prebid.js that referenced this pull request Jun 22, 2020
* appnexus adapter : include hb_source in request to server

* add unit tests

* Revert "add unit tests"

This reverts commit 7b6f97c.

* Revert "appnexus adapter : include hb_source in request to server"

This reverts commit 2a24271.

* move hb_source to tag level

* update if condition for adpod

Co-authored-by: sumit sharma <sumit.sharma1@SYNPUNLT9114TFL.SYNAPPNXS.local>
Co-authored-by: sumit sharma <sumit.sharma1@SYNPUNLT9114TFL.appnexus.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants