Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-auction filters and pbAdslot support - legacy branch #4751

Merged
merged 2 commits into from
Jan 17, 2020

Conversation

idettman
Copy link
Contributor

@idettman idettman commented Jan 17, 2020

Type of change

  • Feature

Description of change

Pre-auction filters and pbadslot support for legacy 2.x branch

  1. The pbAdSlot attribute is added to the Prebid Ad Unit in the First Party Data context
var AdUnit={
   code: "40989gjr9e98ajrosiero",
   fpd: {
     context: {
        pbAdSlot: "/1111111/homepage/med-rect-2"
     }
   },
};
  1. define pre-auction filter function
var setPbAdSlot = function setPbAdSlot(adunits) {
    console.log('setPbAdSlot called');
    // ... logic to find and set fpd.context.pbAdSlot for each AdUnit ...
};
pbjs.onEvent('onBeforeRequestBids', setPbAdSlot);
  1. The Prebid Server Bid Adapter must pass the Prebid AdSlot through the OpenRTB request in imp[].ext.context.data.adslot
{
  imp: [{
    ext: {
      context: {
        data: {
          adslot: "/1111111/homepage/med-rect-2"
        }
      }
    }
  }]
}

Isaac A. Dettman added 2 commits January 16, 2020 19:06
* Add microadBidAdapter

* Remove unnecessary encodeURIComponent from microadBidAdapter

* Submit Advangelists Prebid Adapter

* Submit Advangelists Prebid Adapter 1.1

* Correct procudtion endpoint for prebid

* analytics update with wrapper name

* reverted error merge

* update changed default value of netRevenue to true

* add beforeRequestBids event

* add pbAdSlot support to pbs adapter

* update jsdoc comment for on before request bids event

* add pbAdSlot support to rubicon adapter

* added more tests

* update code comment

* add api test, update event to emit from adapterManager

* add multi-bid api test

* added pbAdSlot to rubicon bid adapter video bid request

* added ext to server video path in rp adapter pbAdSlot

* fix for pb video ortb path

* fix for consistency with pb server

* update obj path to fpd.context.pbAdSlot

* add leading slash removal to all outputs of pbAslot

* revert to previous branch reviewed

* revert to previous branch reviewed

* fix merge errors

(cherry picked from commit fa13966)
@idettman idettman changed the title Add pbadslot legacy Pre-auction filters and pbAdslot support - legacy branch Jan 17, 2020
@idettman idettman self-assigned this Jan 17, 2020
@idettman idettman requested a review from harpere January 17, 2020 05:33
@idettman idettman assigned harpere and unassigned idettman Jan 17, 2020
@harpere harpere merged commit 8ed99d2 into prebid:2.44.x-legacy Jan 17, 2020
@robertrmartinez robertrmartinez deleted the add-pbadslot-2x-legacy branch July 5, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants