Request to add new bidder #4545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
envivoBidder is the new adapter we want to integrate with prebid.js
Fawke
reviewed
Dec 10, 2019
modules/envivoBidAdapter.js
Outdated
|
|
||
| const SUPPORTED_AD_TYPES = [BANNER, VIDEO]; | ||
| const BIDDER_CODE = 'envivo'; | ||
| const DOMAIN = 'http://ad.nvivo.tv/'; |
There was a problem hiding this comment.
We're deprecating the use of http with the prebid-3.0 release. We recommend you change this to https to be part of the new prebid-3.0 release.
There was a problem hiding this comment.
As you said, we have changed from http to https.
|
@envivoBidder Hi, can you please update the docs on this repo? https://github.com/prebid/prebid.github.io |
|
@envivoBidder I was trying to test the video (instream) mediaType with the test params you provided in the md file. I'm getting a CORS error when I do so. Can you make some changes at your server to resolve this? Thanks. |
Fawke
approved these changes
Dec 20, 2019
tadam75
pushed a commit
to smartadserver/Prebid.js
that referenced
this pull request
Jan 9, 2020
* Request to add new bidder envivoBidder is the new adapter we want to integrate with prebid.js * Add files via upload * Update envivoBidAdapter.md * Update envivoBidAdapter.js * Update envivoBidAdapter_spec.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
envivoBidder is the new adapter we want to integrate with prebid.js
Type of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
A link to a PR on the docs repo at https://github.com/prebid/prebid.github.io/
PR link Create envivo.md prebid.github.io#1699
Other information