Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update and refactor of consumable adapter #2962

Merged
merged 1 commit into from
Aug 13, 2018
Merged

update and refactor of consumable adapter #2962

merged 1 commit into from
Aug 13, 2018

Conversation

naffis
Copy link
Contributor

@naffis naffis commented Aug 10, 2018

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Refactor and updates to the Consumable adapter.

Be sure to test the integration with your adserver using the Hello World sample page.

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

prebid/prebid.github.io#923

Other information

@jaiminpanchal27 jaiminpanchal27 self-assigned this Aug 10, 2018
@naffis
Copy link
Contributor Author

naffis commented Aug 13, 2018

Hi @jaiminpanchal27 any updates on this? We are hoping to get this merged before the next release. The docs PR is approved prebid/prebid.github.io#923. Thanks.

@jaiminpanchal27 jaiminpanchal27 merged commit 970e863 into prebid:master Aug 13, 2018
@naffis naffis deleted the consumable-refactor branch August 14, 2018 18:36
florevallatmrf pushed a commit to Marfeel/Prebid.js that referenced this pull request Sep 6, 2018
StefanWallin pushed a commit to mittmedia/Prebid.js that referenced this pull request Sep 28, 2018
ghost pushed a commit to devunrulymedia/Prebid.js that referenced this pull request Jan 30, 2019
AlessandroDG pushed a commit to simplaex/Prebid.js that referenced this pull request Mar 26, 2019
AlessandroDG pushed a commit to simplaex/Prebid.js that referenced this pull request Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants