Feature : Display counter at Adslot level #2940
Conversation
src/adUnits.js
Outdated
| return deepAccess(adUnits, `${adunit}.counter`) || 0; | ||
| } | ||
|
|
||
| exports.adunitCounter = { |
There was a problem hiding this comment.
new modules should prefer ES6 module interface (ie import / export).
src/adUnits.js
Outdated
| function incrementCounter(adunit) { | ||
| adUnits[adunit] = adUnits[adunit] || {}; | ||
| adUnits[adunit].counter = (deepAccess(adUnits, `${adunit}.counter`) + 1) || 1; | ||
| return adUnits[adunit].counter; |
There was a problem hiding this comment.
It is increment and get rather than just increment. Will be useful for developer.
src/adUnits.js
Outdated
| return adUnits[adunit].counter; | ||
| } | ||
|
|
||
| function getCounter(adunit) { |
There was a problem hiding this comment.
please add jsdoc definitions to public functions.
|
@mkendall07 Have made required changes, please check the same. |
modules/medianetBidAdapter.js
Outdated
| @@ -122,7 +122,8 @@ function slotParams(bidRequest) { | |||
| let params = { | |||
| id: bidRequest.bidId, | |||
| ext: { | |||
| dfp_id: bidRequest.adUnitCode | |||
| dfp_id: bidRequest.adUnitCode, | |||
| display_count: bidRequest.displayCount | |||
There was a problem hiding this comment.
err small nit with this name. Isn't it more accurate as bidRequestsCount? We don't know if it was displayed. Or auctionParticipationCount
|
Please also submit a PR to update the documentation for the bidder. Somewhere in here would be good: http://prebid.org/dev-docs/bidder-adaptor.html#bidder-adaptor-Building-the-Request |
|
@mkendall07 @snapwich @jaiminpanchal27 have renamed it to |
Type of change
Description of change
As discussed in #2295 thread, some bidders will be interested in getting the Display Counter which is added in this PR.
buildRequestsof an adapter will be called with an keydisplayCountat adSlot level.This PR also contains Media.net adapter integration with this feature
Other information
As discussed in #2802 with @mkendall07 , the ad unit counter variable is set private.