Fidelity Media fmxSSP. Adding GDPR Support #2935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaiminpanchal27
requested changes
Aug 6, 2018
modules/fidelityBidAdapter.js
Outdated
| var gdpr = 0; | ||
| var consent_str = ''; | ||
| var consent_given = 0; | ||
| if (typeof gdprConsent.gdprApplies !== 'undefined') { |
There was a problem hiding this comment.
Move this duplicate logic in one function
There was a problem hiding this comment.
Thanks for the review. We are making necessary changes.
There was a problem hiding this comment.
@jaiminpanchal27 Changes were made, please review.
jaiminpanchal27
approved these changes
Aug 13, 2018
florevallatmrf
pushed a commit
to Marfeel/Prebid.js
that referenced
this pull request
Sep 6, 2018
* Add GDPR support * Add GDPR Support * Add GDPR support. Amended .js
StefanWallin
pushed a commit
to mittmedia/Prebid.js
that referenced
this pull request
Sep 28, 2018
* Add GDPR support * Add GDPR Support * Add GDPR support. Amended .js
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
* Add GDPR support * Add GDPR Support * Add GDPR support. Amended .js
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
* Add GDPR support * Add GDPR Support * Add GDPR support. Amended .js
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
* Add GDPR support * Add GDPR Support * Add GDPR support. Amended .js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Fidelity Media fmxSSP. Adding GDPR Support
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information