Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AJA adapter #2934

Merged
merged 9 commits into from
Aug 15, 2018
Merged

AJA adapter #2934

merged 9 commits into from
Aug 15, 2018

Conversation

yoshito0523
Copy link
Contributor

@yoshito0523 yoshito0523 commented Aug 3, 2018

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
[
  {
    code: 'test',
    mediaTypes: {
      banner: {
        sizes: [
          [300, 250]
        ],
      }
    },
    bids: [{
      bidder: 'aja',
      params: {
        asi: 'szs4htFiR'
      }
    }]
  },
  {
    code: 'test',
    mediaTypes: {
      video: {
        context: 'outstream',
        playerSize: [300, 250]
      }
    },
    bids: [{
      bidder: 'aja',
      params: {
        asi: 'Kp2O2tFig'
      }
    }]
  }
]

@yoshito0523
Copy link
Contributor Author

@idettman Could you please review this PR and let me know?

@yoshito0523
Copy link
Contributor Author

@mike-chowla @idettman
Hi, Mike and Isaac.
We are waiting for your review over 7 days, and still not receive your response.
If possible, I want you to review my code in a few days.

Best Regards,
Yoshito Oe

Copy link
Contributor

@idettman idettman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@idettman idettman merged commit 2fb1d95 into prebid:master Aug 15, 2018
florevallatmrf pushed a commit to Marfeel/Prebid.js that referenced this pull request Sep 6, 2018
* AJA Bid Adapter

* fix markdown

* delete log

* multiple tracking support

* semicolon

* fix test parameters

* v1 -> v2

* add parameters

* JPY -> USD
StefanWallin pushed a commit to mittmedia/Prebid.js that referenced this pull request Sep 28, 2018
* AJA Bid Adapter

* fix markdown

* delete log

* multiple tracking support

* semicolon

* fix test parameters

* v1 -> v2

* add parameters

* JPY -> USD
ghost pushed a commit to devunrulymedia/Prebid.js that referenced this pull request Jan 30, 2019
* AJA Bid Adapter

* fix markdown

* delete log

* multiple tracking support

* semicolon

* fix test parameters

* v1 -> v2

* add parameters

* JPY -> USD
AlessandroDG pushed a commit to simplaex/Prebid.js that referenced this pull request Mar 26, 2019
* AJA Bid Adapter

* fix markdown

* delete log

* multiple tracking support

* semicolon

* fix test parameters

* v1 -> v2

* add parameters

* JPY -> USD
AlessandroDG pushed a commit to simplaex/Prebid.js that referenced this pull request Mar 26, 2019
* AJA Bid Adapter

* fix markdown

* delete log

* multiple tracking support

* semicolon

* fix test parameters

* v1 -> v2

* add parameters

* JPY -> USD
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants