-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Legacy Sortable bid adapter #2915
Conversation
* copy over sortable adapter as well as its spce test and md * fix missing utils.isPlainObject
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Verified test parameters from sortableBidAdapter.md, received valid results from the /openrtb2/auction endpoint.
modules/sortableBidAdapter.js
Outdated
}, | ||
|
||
onTimeout(details) { | ||
fetch(`//${SERVER_URL}/prebid/timeout`, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fetch isn't supported by Internet Explorer 10 or 11, and prebid supports IE 10+: https://caniuse.com/#search=fetch
The prebid ajax function should work as a substitute. If you search the adapters codebase, you'll find usage examples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove usages of the 'fetch' api (fetch is not supported by Internet Explorer 10 - 11)
@idettman I removed fetch and used ajax instead. Checks failed but seem not relevant to this change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Note: the initial circle test failed with an error not related to this adapter, but I ran circleci again and it resolved :)
Type of change
Description of change
The PR backporst Sortable bid adapter to legacy. GDPR support is removed and
utils.isPlainObject(...)
is replaced withutils.isA(..., 'Object')
.