switch to circleci instead of travis-ci #2895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnellbaker
approved these changes
Jul 26, 2018
There was a problem hiding this comment.
This setup appears to be working as expected. I made my own fork of Prebid.js, created a test branch, introduced a find error in a unit test and created a PR request here (#2898).
The circleci check for that PR failed as expected; job url here
jaiminpanchal27
approved these changes
Aug 1, 2018
florevallatmrf
pushed a commit
to Marfeel/Prebid.js
that referenced
this pull request
Sep 6, 2018
* circleci test * test push * update docker image * update docker image * sudo * add npm cache, update to use browserstack * update env vars * download local binary * download local binary * run in background * rename key * include circleci test * echo username * echo username * remove local identifier * remove .travis.yml
StefanWallin
pushed a commit
to mittmedia/Prebid.js
that referenced
this pull request
Sep 28, 2018
* circleci test * test push * update docker image * update docker image * sudo * add npm cache, update to use browserstack * update env vars * download local binary * download local binary * run in background * rename key * include circleci test * echo username * echo username * remove local identifier * remove .travis.yml
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
* circleci test * test push * update docker image * update docker image * sudo * add npm cache, update to use browserstack * update env vars * download local binary * download local binary * run in background * rename key * include circleci test * echo username * echo username * remove local identifier * remove .travis.yml
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
* circleci test * test push * update docker image * update docker image * sudo * add npm cache, update to use browserstack * update env vars * download local binary * download local binary * run in background * rename key * include circleci test * echo username * echo username * remove local identifier * remove .travis.yml
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
* circleci test * test push * update docker image * update docker image * sudo * add npm cache, update to use browserstack * update env vars * download local binary * download local binary * run in background * rename key * include circleci test * echo username * echo username * remove local identifier * remove .travis.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches to circleci for a CI system. The motivation was so we can run browserstack tests on PRs submitted from forks. This is possible because circleci allows you to share private env vars to forked builds.
Example of an external fork PR is here: #2897
Benefits:
Cons: