Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add between adapter #2722

Merged
merged 3 commits into from
Aug 1, 2018
Merged

add between adapter #2722

merged 3 commits into from
Aug 1, 2018

Conversation

Shimogatsu
Copy link
Contributor

@Shimogatsu Shimogatsu commented Jun 13, 2018

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@@ -0,0 +1,29 @@
# Overview

Module Name: Example Bidder Adapter
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the template and add actual contact info.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

{
bidder: "between",
params: {
placementId: '12345',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is 12345 an actual bid parameter?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, its test parameter

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated pull req and i did pull req in prebid.io

@bretg
Copy link
Collaborator

bretg commented Jun 13, 2018

Please provide a PR for documentation in https://github.com/prebid/prebid.github.io

@stale
Copy link

stale bot commented Jul 5, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot removed the stale label Jul 11, 2018
@Shimogatsu
Copy link
Contributor Author

i updated pull request

@bretg
Copy link
Collaborator

bretg commented Jul 13, 2018

my review just covers the docs -- @idettman - please cover the body of the adapter. Thanks.

@Shimogatsu
Copy link
Contributor Author

Guys, do you need anything from me to proceed? What’s our next step here?

@madm1keru
Copy link

@bretg @idettman please, give us any feedback, we have enough publishers waiting for this pull request to be merged. LEt us know if you need any additional info or file changes.

Copy link
Contributor

@idettman idettman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Shimogatsu
Copy link
Contributor Author

Done

@madm1keru
Copy link

@idettman we've fixed merge conflicts without any changes in adapter itself.
Could you pls proceed with this merge?

@idettman idettman merged commit a8580b5 into prebid:master Aug 1, 2018
florevallatmrf pushed a commit to Marfeel/Prebid.js that referenced this pull request Sep 6, 2018
* add between adapter

* add md dexcription about between adapter
StefanWallin pushed a commit to mittmedia/Prebid.js that referenced this pull request Sep 28, 2018
* add between adapter

* add md dexcription about between adapter
ghost pushed a commit to devunrulymedia/Prebid.js that referenced this pull request Jan 30, 2019
* add between adapter

* add md dexcription about between adapter
AlessandroDG pushed a commit to simplaex/Prebid.js that referenced this pull request Mar 26, 2019
* add between adapter

* add md dexcription about between adapter
AlessandroDG pushed a commit to simplaex/Prebid.js that referenced this pull request Mar 26, 2019
* add between adapter

* add md dexcription about between adapter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants