-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add between adapter #2722
add between adapter #2722
Conversation
modules/betweenBidAdapter.md
Outdated
@@ -0,0 +1,29 @@ | |||
# Overview | |||
|
|||
Module Name: Example Bidder Adapter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the template and add actual contact info.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
modules/betweenBidAdapter.md
Outdated
{ | ||
bidder: "between", | ||
params: { | ||
placementId: '12345', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is 12345 an actual bid parameter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope, its test parameter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated pull req and i did pull req in prebid.io
Please provide a PR for documentation in https://github.com/prebid/prebid.github.io |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
i updated pull request |
my review just covers the docs -- @idettman - please cover the body of the adapter. Thanks. |
Guys, do you need anything from me to proceed? What’s our next step here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Done |
@idettman we've fixed merge conflicts without any changes in adapter itself. |
* add between adapter * add md dexcription about between adapter
* add between adapter * add md dexcription about between adapter
* add between adapter * add md dexcription about between adapter
* add between adapter * add md dexcription about between adapter
* add between adapter * add md dexcription about between adapter
Type of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information