Audience Network (legacy): backport native non-IAB size fix #2558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The unit tests intermittently fail for an unrelated adapter, which probably relates to #1639
|
mkendall07
requested changes
May 24, 2018
modules/audienceNetworkBidAdapter.js
Outdated
| @@ -49,13 +51,37 @@ const expandSize = size => size.split('x').map(Number); | |||
| */ | |||
| const isValidSize = size => ['300x250', '320x50'].includes(size); | |||
There was a problem hiding this comment.
this isn't a safe use of includes.
There was a problem hiding this comment.
Thanks, good spot, updated.
|
@lovell ^^ fyi |
7a27ffd to
76b8d4f
Compare
idettman
approved these changes
May 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Hello, this PR is to backport bug fixes #2203 and #2417 to the "legacy" 0.x release branch.
This work was commissioned and paid for by Facebook.