Add user sync callback for OpenX adaptor #2409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 16, 2018 15:06
jaiminpanchal27
requested changes
Apr 17, 2018
| spec.interpretResponse({body: bidResponse}, bidRequest); | ||
| sinon.assert.calledWith(userSync.registerSync, 'iframe', 'openx', 'http://testpixels.net'); | ||
| }); | ||
|
|
||
| it('should register a beacon', () => { |
There was a problem hiding this comment.
@haohany Please add unit test for getUserSync
There was a problem hiding this comment.
Updated with tests. Thanks for the review.
added 2 commits
April 17, 2018 14:10
jaiminpanchal27
approved these changes
Apr 18, 2018
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
* OpenX user sync callback * bump version * Get user sync url from responses if available * Missing semicolon * Add user sync tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Add user sync callback for OpenX adaptor