-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create rtbdemandAdkBidAdapter_spec.js #2352
Conversation
Added rtbdemandadk.md in PR as well prebid/prebid.github.io#696 and included the unit test file |
@rtbdemand there appear to be some test failures in the Travis build. Can you please investigate and fix? below is a copy of the error details:
|
Looking at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated added width and height fields in response time breaking test
Same is fixed..By when will appear in prebid page now |
* 'master' of https://github.com/prebid/Prebid.js: (211 commits) Increment Pre Version Prebid 1.8.0 Release Make eslint aware of the custom import paths (prebid#2292) send travis-ci notifications to slack (prebid#2404) send appnexus usePaymentRule info to prebid-server ortb request (prebid#2351) convert AN bid params to underscore formatting for pbs (prebid#2385) EbdrAdapter add usersync (prebid#2407) Add outstream renderer to Beachfront adapter (prebid#2403) Add analytics adapter by Sigmoid (prebid#2316) deprecate loadScript and add loadExternalScript (prebid#2391) Removed the ability for to override any standard query parameters (prebid#2402) Unit test failures (prebid#2405) Add Unruly Bid Adapter (prebid#2326) Added VIS.X Bidder Adapter (prebid#2359) Smart: Add prebid version in the data payload (prebid#2394) add support for video bids to use an impression tracking URL (prebid#2365) Create rtbdemandAdkBidAdapter_spec.js (prebid#2352) Widespace adapter (prebid#2283) Add: Vuble Analytics Adapter (prebid#2331) fixes prebid#2353 - not appending hb_uuid and hb_cache_id (prebid#2363) ... # Conflicts: # test/spec/modules/rockyouBidAdapter_spec.js
Type of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information