Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenX Adapter: Video Support Update #2342

Merged
merged 1 commit into from
Apr 12, 2018

Conversation

jimee02
Copy link
Contributor

@jimee02 jimee02 commented Apr 4, 2018

Type of change

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)

Description of change

Bugfix

Feature

Refactors

  • Added test coverage for user syncing and beaconing for banner and video responses
  • Removed unnecessary query parameter 'ef'
  • Switched custom functions with utility functions
  • Refactored codebase for easier readability

@mkendall07
Copy link
Member

This pull request introduces 1 alert when merging d902f9a6101cda08cc3c5194eeab1020ed12b022 into 216f01c - view on lgtm.com

new alerts:

  • 1 for Superfluous trailing arguments

Comment posted by lgtm.com

@mkendall07
Copy link
Member

This pull request introduces 1 alert and fixes 1 when merging aa779679c25ed5d5c600f51ce0f24606f2b8068b into 216f01c - view on lgtm.com

new alerts:

  • 1 for Syntax error

fixed alerts:

  • 1 for Useless assignment to local variable

Comment posted by lgtm.com

Added beacon tracking for video requests via user sync
Added test coverage for user syncing and beaconing for banner and video responses
Fixed bug in video where request is always in http instead of using current protocol
Removed unnecessary query parameter 'ef'
Switched custom functions with utility functions
Refactored codebase for easier readability
@jaiminpanchal27 jaiminpanchal27 merged commit 76e079a into prebid:master Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants