Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smart: New parameters for in-app ads #2325

Merged
merged 7 commits into from
Apr 13, 2018

Conversation

ytyukhnin
Copy link
Contributor

@ytyukhnin ytyukhnin commented Mar 29, 2018

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

This feature will allow publishers to pass additional parameters for their in-app inventory. These parameters are:

  • buId for application bundle id
  • appName for application name
  • ckId for unique id

Please use the following test parameters:

{
            code: 'div-gpt-ad-1460505748561-0',
            sizes: [[300, 250]],  // a display size
            bids: [{
              bidder: "smart",
              params: {
                domain: 'http://ww251.smartadserver.com',
                siteId: 207435,
                pageId: 896536,
                formatId: 62913,
                buId: "com.test.bundle",
                ckId: 1234567890,
                appName: "TestApp"
              }
            }]
          }

@ytyukhnin
Copy link
Contributor Author

Here is a PR for the corresponding docs
prebid/prebid.github.io#693

@ytyukhnin
Copy link
Contributor Author

Hi @ndhimehta ,
Any news on this?

Thank you.

@ytyukhnin
Copy link
Contributor Author

Hi @jsnellbaker
Any news on this PR?

Thank you.

@jsnellbaker jsnellbaker assigned jsnellbaker and unassigned ndhimehta Apr 13, 2018
@jsnellbaker jsnellbaker self-requested a review April 13, 2018 12:05
Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ytyukhnin Sorry for the delay, the changes look good and seemed to be working.

Since you have new params, could you also update the modules/smartadserverBidAdapter.md in this repo so that it's consistent with the docs-repo?

We should be good to go at that point. Thanks!

@ytyukhnin
Copy link
Contributor Author

Hi @jsnellbaker

Thank you for your reply.
It has been updated in c6235bf

Thanks in advance.

@jsnellbaker jsnellbaker merged commit c805507 into prebid:master Apr 13, 2018
@ytyukhnin ytyukhnin deleted the Feature-207 branch May 14, 2018 09:12
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
* Fix bug when multi bids

* New fields: bundleId, uid, appName

* Uid fix according to its type

* Params names changed for consistency

* adapter docs update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants