Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update rubicon video position default value for legacy version #2307

Merged
merged 1 commit into from
Apr 4, 2018
Merged

update rubicon video position default value for legacy version #2307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/rubiconBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ export const spec = {
let slotData = {
site_id: params.siteId,
zone_id: params.zoneId,
position: params.position || 'btf',
position: params.position === 'atf' || params.position === 'btf' ? params.position : 'unknown',
floor: parseFloat(params.floor) > 0.01 ? params.floor : 0.01,
element_id: bidRequest.adUnitCode,
name: bidRequest.adUnitCode,
Expand Down
77 changes: 62 additions & 15 deletions test/spec/modules/rubiconBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import { expect } from 'chai';
import {expect} from 'chai';
import adapterManager from 'src/adaptermanager';
import { spec, masSizeOrdering, resetUserSync } from 'modules/rubiconBidAdapter';
import { parse as parseQuery } from 'querystring';
import { newBidder } from 'src/adapters/bidderFactory';
import { userSync } from 'src/userSync';
import { config } from 'src/config';
import {spec, masSizeOrdering, resetUserSync} from 'modules/rubiconBidAdapter';
import {parse as parseQuery} from 'querystring';
import {newBidder} from 'src/adapters/bidderFactory';
import {userSync} from 'src/userSync';
import {config} from 'src/config';

var CONSTANTS = require('src/constants.json');

Expand Down Expand Up @@ -208,7 +208,8 @@ describe('the rubicon adapter', () => {

it('should send digitrust params', () => {
window.DigiTrust = {
getUser: function() {}
getUser: function () {
}
};
sandbox.stub(window.DigiTrust, 'getUser', () =>
({
Expand Down Expand Up @@ -253,7 +254,8 @@ describe('the rubicon adapter', () => {

it('should not send digitrust params due to optout', () => {
window.DigiTrust = {
getUser: function() {}
getUser: function () {
}
};
sandbox.stub(window.DigiTrust, 'getUser', () =>
({
Expand Down Expand Up @@ -281,7 +283,8 @@ describe('the rubicon adapter', () => {

it('should not send digitrust params due to failure', () => {
window.DigiTrust = {
getUser: function() {}
getUser: function () {
}
};
sandbox.stub(window.DigiTrust, 'getUser', () =>
({
Expand Down Expand Up @@ -493,6 +496,50 @@ describe('the rubicon adapter', () => {
expect(slot.visitor).to.have.property('lastsearch').that.equals('iphone');
});

it('should send request with proper ad position', () => {
createVideoBidderRequest();
let positionBidderRequest = clone(bidderRequest);
positionBidderRequest.bids[0].params.position = 'atf';
let [request] = spec.buildRequests(positionBidderRequest.bids, positionBidderRequest);
let post = request.data;
let slot = post.slots[0];

expect(slot.position).to.equal('atf');

positionBidderRequest = clone(bidderRequest);
positionBidderRequest.bids[0].params.position = 'btf';
[request] = spec.buildRequests(positionBidderRequest.bids, positionBidderRequest);
post = request.data;
slot = post.slots[0];

expect(slot.position).to.equal('btf');

positionBidderRequest = clone(bidderRequest);
positionBidderRequest.bids[0].params.position = 'unknown';
[request] = spec.buildRequests(positionBidderRequest.bids, positionBidderRequest);
post = request.data;
slot = post.slots[0];

expect(slot.position).to.equal('unknown');

positionBidderRequest = clone(bidderRequest);
positionBidderRequest.bids[0].params.position = '123';
[request] = spec.buildRequests(positionBidderRequest.bids, positionBidderRequest);
post = request.data;
slot = post.slots[0];

expect(slot.position).to.equal('unknown');

positionBidderRequest = clone(bidderRequest);
delete positionBidderRequest.bids[0].params.position;
expect(positionBidderRequest.bids[0].params.position).to.equal(undefined);
[request] = spec.buildRequests(positionBidderRequest.bids, positionBidderRequest);
post = request.data;
slot = post.slots[0];

expect(slot.position).to.equal('unknown');
});

it('should allow a floor price override', () => {
createVideoBidderRequest();

Expand Down Expand Up @@ -603,7 +650,7 @@ describe('the rubicon adapter', () => {
]
};

let bids = spec.interpretResponse({ body: response }, {
let bids = spec.interpretResponse({body: response}, {
bidRequest: bidderRequest.bids[0]
});

Expand Down Expand Up @@ -655,7 +702,7 @@ describe('the rubicon adapter', () => {
}]
};

let bids = spec.interpretResponse({ body: response }, {
let bids = spec.interpretResponse({body: response}, {
bidRequest: bidderRequest.bids[0]
});

Expand All @@ -678,7 +725,7 @@ describe('the rubicon adapter', () => {
'ads': []
};

let bids = spec.interpretResponse({ body: response }, {
let bids = spec.interpretResponse({body: response}, {
bidRequest: bidderRequest.bids[0]
});

Expand All @@ -702,7 +749,7 @@ describe('the rubicon adapter', () => {
}]
};

let bids = spec.interpretResponse({ body: response }, {
let bids = spec.interpretResponse({body: response}, {
bidRequest: bidderRequest.bids[0]
});

Expand All @@ -712,7 +759,7 @@ describe('the rubicon adapter', () => {
it('should handle an error because of malformed json response', () => {
let response = '{test{';

let bids = spec.interpretResponse({ body: response }, {
let bids = spec.interpretResponse({body: response}, {
bidRequest: bidderRequest.bids[0]
});

Expand Down Expand Up @@ -753,7 +800,7 @@ describe('the rubicon adapter', () => {
'account_id': 7780
};

let bids = spec.interpretResponse({ body: response }, {
let bids = spec.interpretResponse({body: response}, {
bidRequest: bidderRequest.bids[0]
});

Expand Down