only do video caching if we don't already have a videoCacheKey #2143
Conversation
src/auction.js
Outdated
| } else { | ||
| }); | ||
| } else if (!bidResponse.vastUrl) { | ||
| bidResponse.vastUrl = getCacheUrl(bidResponse.videoCacheKey); |
There was a problem hiding this comment.
We may not need line 249. When videoCacheKey exists, publisher is not using cache.url, publisher should use either Prebid Server cache with cacheMarkup (videoCacheKey = cache_id, vastUrl = cache_url) or its own cache server (videoCacheKey = imp_id or anything client side adapter wants, vastUrl = creative_depot_url or anything client side adapter wants). And getCacheUrl method is using cache.url to build the Url.
There was a problem hiding this comment.
I know we're not using this line (because we return vastUrl with videoCacheKey), but I'm not sure if other's might use it. Is there no scenario where an adapter would return the videoCacheKey but expect that key to work against the url set with cache.url?
There was a problem hiding this comment.
And if that scenario is not possible, then this line should probably be substituted with some kind of errors or warnings.
There was a problem hiding this comment.
Agree, we can throw errors or warnings here. videoCacheKey and vastUrl should be well defined in all cache scenarios.
* master: Update Vertoz adapter for Prebid 1.0 (prebid#2104) Add multiple bids request (prebid#2136) [NEW Adapter] RTBHouseBidAdapter (prebid#2184) Update Innity Adapter to Prebid.js v1.0 (prebid#2180) Update Adyoulike Adapter to prebid 1.0 (prebid#2077) Change bidderCode for DAN Marketplace Bid Adapter (prebid#2183) only count bid timeouts if bidder didn't call done. fixes prebid#2146 (prebid#2154) [Edit BidAdapter] rxrtb adapter for Perbid.js 1.0 (prebid#2182) Update NasmediaAdmixer adapter (prebid#2164) only do video caching if we don't already have a videoCacheKey (prebid#2143)
…d#2143) * only do video caching if we don't already have a videoCacheKey * log error for missing vastUrl when videoCacheKey specified
Type of change
Description of change
addBidResponseshould not cache video response if adapter already returns avideoCacheKey(indicating that it already cached).