-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yieldmo Bid Adapter Update #2054
Conversation
environments finished building request markdown and test cases pr valid bid requests all tests but user sync added usersync and interpretresponse environments finished building request markdown and test cases pr valid bid requests all tests but user sync fixed unti tests merge conflicts added mraid check and catch for window.top added height and width, updated tests, fixed interpretResponse, updated md file cleaning up the rebase added usersync and interpretresponse environments finished building request markdown and test cases pr valid bid requests all tests but user sync fixed unti tests added usersync and interpretresponse environments finished building request markdown and test cases pr valid bid requests all tests but user sync added mraid check and catch for window.top added height and width, updated tests, fixed interpretResponse, updated md file
environments finished building request markdown and test cases pr valid bid requests all tests but user sync added usersync and interpretresponse environments finished building request markdown and test cases pr valid bid requests all tests but user sync fixed unti tests merge conflicts added mraid check and catch for window.top added height and width, updated tests, fixed interpretResponse, updated md file cleaning up the rebase added usersync and interpretresponse environments finished building request markdown and test cases pr valid bid requests all tests but user sync fixed unti tests added usersync and interpretresponse environments finished building request markdown and test cases pr valid bid requests all tests but user sync added mraid check and catch for window.top added height and width, updated tests, fixed interpretResponse, updated md file fix tests' fixed rebase and updated markdown file fixed linting error fixed test test fix
environments finished building request markdown and test cases pr valid bid requests all tests but user sync added usersync and interpretresponse environments finished building request markdown and test cases pr valid bid requests all tests but user sync fixed unti tests merge conflicts added mraid check and catch for window.top added height and width, updated tests, fixed interpretResponse, updated md file cleaning up the rebase added usersync and interpretresponse environments finished building request markdown and test cases pr valid bid requests all tests but user sync fixed unti tests added usersync and interpretresponse environments finished building request markdown and test cases pr valid bid requests all tests but user sync added mraid check and catch for window.top added height and width, updated tests, fixed interpretResponse, updated md file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @merrdy,
Thanks for submitting this adapter! Overall the code looks fine to me, however I'm having some trouble trying to test the adapter on the hello_world.html page. When I looked in the console, I'm seeing an Access-Control-Allow-Origin error when it's attempting to call the yieldmo server. Can you take a look into this on your end?
Hey @jsnellbaker, The issue was that the id in the placementId field is currently not in production, so you were probably getting a 204 when pinging our server. If you comment out that id, you should be able to get an ad. Is that alright? Otherwise I can ask our ad servers to send a response for that placementId. Thanks! |
Hey @merrdy, I did try to comment out the |
Okay, I'll talk to ad serving. The other issue might be that you have to be emulating mobile in order to get an ad. So you might have to refresh after switching to mobile view in order to get an ad. Sorry I thought I mentioned the mobile mode in the notes above, but I guess I didn't! |
Okay, I've updated the docs and the description above such that the placementId given should result in an ad. Don't forget to emulate mobile mode when you're trying to get the ad. We only serve on mobile, so an ad request from desktop will get a 204. Thanks for being patient with me about this! |
@merrdy Thanks for submitting the changes and helping to enable the ad unit for testing. I verified the delivery is working when I'm emulating and not when I'm using my desktop (as you noted). LGTM |
Okay, thanks! |
Need docs PR to merge. Please submit a PR to the docs repo to add a file for your adapter to the bidders directory so your adapter's params will appear on the bidders page. Thank you for contributing |
We've reopened our pr to update the docs here: prebid/prebid.github.io#469 (comment). Thanks! |
* added usersync and interpretresponse environments finished building request markdown and test cases pr valid bid requests all tests but user sync added usersync and interpretresponse environments finished building request markdown and test cases pr valid bid requests all tests but user sync fixed unti tests merge conflicts added mraid check and catch for window.top added height and width, updated tests, fixed interpretResponse, updated md file cleaning up the rebase added usersync and interpretresponse environments finished building request markdown and test cases pr valid bid requests all tests but user sync fixed unti tests added usersync and interpretresponse environments finished building request markdown and test cases pr valid bid requests all tests but user sync added mraid check and catch for window.top added height and width, updated tests, fixed interpretResponse, updated md file * fix tests' * fixed rebase and updated markdown file * added usersync and interpretresponse environments finished building request markdown and test cases pr valid bid requests all tests but user sync added usersync and interpretresponse environments finished building request markdown and test cases pr valid bid requests all tests but user sync fixed unti tests merge conflicts added mraid check and catch for window.top added height and width, updated tests, fixed interpretResponse, updated md file cleaning up the rebase added usersync and interpretresponse environments finished building request markdown and test cases pr valid bid requests all tests but user sync fixed unti tests added usersync and interpretresponse environments finished building request markdown and test cases pr valid bid requests all tests but user sync added mraid check and catch for window.top added height and width, updated tests, fixed interpretResponse, updated md file fix tests' fixed rebase and updated markdown file fixed linting error fixed test test fix * added usersync and interpretresponse environments finished building request markdown and test cases pr valid bid requests all tests but user sync added usersync and interpretresponse environments finished building request markdown and test cases pr valid bid requests all tests but user sync fixed unti tests merge conflicts added mraid check and catch for window.top added height and width, updated tests, fixed interpretResponse, updated md file cleaning up the rebase added usersync and interpretresponse environments finished building request markdown and test cases pr valid bid requests all tests but user sync fixed unti tests added usersync and interpretresponse environments finished building request markdown and test cases pr valid bid requests all tests but user sync added mraid check and catch for window.top added height and width, updated tests, fixed interpretResponse, updated md file * fix tests' * fixed rebase and updated markdown file * update placementId * lint error
Type of change
Description of change
Updating Yieldmo Prebid Adapter to meet Prebid 1.0 specs
Be sure to test the integration with your adserver using the Hello World sample page.