Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test fix in IE for adxcgAnalytics Adapter #1929

Merged
merged 2 commits into from
Dec 6, 2017
Merged

Unit test fix in IE for adxcgAnalytics Adapter #1929

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b133be8
IE bug fix
jaiminpanchal27 Dec 6, 2017
846d3f4
get only unique bidders
jaiminpanchal27 Dec 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/adxcgAnalyticsAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ var adxcgAnalyticsAdapter = Object.assign(adapter(
track({eventType, args}) {
if (typeof args !== 'undefined') {
if (eventType === CONSTANTS.EVENTS.BID_TIMEOUT) {
events.bidTimeout = [...new Set(args.map(item => item.bidder))];
events.bidTimeout = args.map(item => item.bidder);
Copy link
Collaborator

@matthewlane matthewlane Dec 6, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set stores unique values, so I think this needs something like filter(utils.uniques) after the map

} else if (eventType === CONSTANTS.EVENTS.AUCTION_INIT) {
events.auctionInit = args;
auctionTimestamp = args.timestamp;
Expand Down