Removed the no-redeclare ESLint exclusion #1444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewlane
reviewed
Aug 2, 2017
There was a problem hiding this comment.
@dbemiller merged an updated to pubwise analytics which will require an update for this rule too, and one comment for your consideration below, otherwise LGTM
| @@ -426,7 +427,7 @@ var IndexExchangeAdapter = function IndexExchangeAdapter() { | |||
| _IndexRequestData.targetAggregate = {'open': {}, 'private': {}}; | |||
|
|
|||
| if (!utils.hasValidBidRequest(bidArr[0].params, requiredParams, ADAPTER_NAME)) { | |||
| for (var i = 0; i < bidArr.length; i++) { | |||
There was a problem hiding this comment.
Any thoughts on changing the var to let (in this loop and the one below)? i gets scoped to the block in that case and then no need for the var i declaration on 419
There was a problem hiding this comment.
much better idea ^^
matthewlane
approved these changes
Aug 3, 2017
philipwatson
pushed a commit
to mbrtargeting/Prebid.js
that referenced
this pull request
Sep 18, 2017
* Removed the no-redeclare exclusion. * Fixed the actual style error. * Fixed the linting errors, and changed var to let for cleaner code.
jbAdyoulike
pushed a commit
to jbAdyoulike/Prebid.js
that referenced
this pull request
Sep 21, 2017
* Removed the no-redeclare exclusion. * Fixed the actual style error. * Fixed the linting errors, and changed var to let for cleaner code.
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
* Removed the no-redeclare exclusion. * Fixed the actual style error. * Fixed the linting errors, and changed var to let for cleaner code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Code style update (formatting, local variables)
Description of change
Removing the no-redeclare ESLint exclusion for #1206