Last bid timeout #1299
Closed
Last bid timeout #1299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…invalid This patch also adds logging for invalid bids.
|
bidmanager has changed to the point where this doesn't make sense any more, so I'll close it |
|
@kitwestneat |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This fixes #1298 as well as refactoring some of the code to make it clearer. The bugfix is commit b5c30ff, the other commits refactor addBidResponse. 045e4ee could also be a bigfix -- it doesn't make sense to me that the bid events are emitted before the bid response is fully built, but I might be missing something.
Other information
Fixes #1298