Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobkoi Bidder Adapter: Initial Release #12647

Merged
merged 4 commits into from
Feb 19, 2025
Merged

Conversation

zeeye
Copy link
Contributor

@zeeye zeeye commented Jan 13, 2025

Type of change

  • New bidder adapter Doc

Description of change

Initial implementation for Mobkoi Bidder Adapter

Other information

Sorry, something went wrong.

Copy link

Tread carefully! This PR adds 1 linter error (possibly disabled through directives):

  • modules/mobkoiAnalyticsAdapter.js (+1 error)

zeeye and others added 3 commits January 27, 2025 15:13
…from Bid Configuration Object (#8)

Configuration Object](https://mobkoi.atlassian.net/browse/MAX-970)

At this stage, we are only focused on bid win events, so there is no
need for analytics adapter integration yet. To streamline the
publisher's configuration for our custom bid adapter integration, we
retrieve adapter parameters directly from the bid configuration object
instead of using "bidderConfiguration."

updated bid adapter doc
…be past to the AdServer (#9)

### [We need the placement ID from Tag and HB Connector to be past to
the AdServer](https://mobkoi.atlassian.net/browse/MAX-956)
@zeeye zeeye changed the title Mobkoi Bidder Adapter: Initial implementation Mobkoi Bidder Adapter: Initial Release Feb 5, 2025
@carlessistare
Copy link

Hi @mmoschovas @ChrisHuie
I hope you’re both doing well. Would you mind taking a look at this PR when you have a moment? It has been open for about a month, and I’d appreciate any initial feedback 🙏

I understand you must receive many similar requests, so thank you for your dedication to keeping this repository at a high standard. If we're missing anything or if further changes are needed, please let us know.

Thank you very much!

@carlessistare
Copy link

Hi @Rothalack @patmmccann ,

I hope you're doing fine.
The PR is open since more than one month and I dropped a comment last week.
Is there a chance that we could have a first review on it, or provide a rough ETA?

Apologies for the persistence, but we just want to ensure we're on the right track.

Thanks so much

@ChrisHuie ChrisHuie merged commit e04bfc2 into prebid:master Feb 19, 2025
6 checks passed
@ChrisHuie ChrisHuie assigned ChrisHuie and unassigned mmoschovas Feb 19, 2025
kiho-shige pushed a commit to DAConsortium/Prebid.js that referenced this pull request Mar 6, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* Mobkoi Bidder Adapter: Initialise implementation

* feat: max-970: Prebid.js Bidder Adapter: Retrieve Adapter Parameters from Bid Configuration Object (#8)

Configuration Object](https://mobkoi.atlassian.net/browse/MAX-970)

At this stage, we are only focused on bid win events, so there is no
need for analytics adapter integration yet. To streamline the
publisher's configuration for our custom bid adapter integration, we
retrieve adapter parameters directly from the bid configuration object
instead of using "bidderConfiguration."

updated bid adapter doc

* feat: max-956: We need the placement ID from Tag and HB Connector to be past to the AdServer (#9)

### [We need the placement ID from Tag and HB Connector to be past to
the AdServer](https://mobkoi.atlassian.net/browse/MAX-956)

* set user.id if available
@zeeye zeeye deleted the bidder-adapter branch March 19, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants