Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add alias freewheel-ssp to stickyadstv bidder adapter #1043

Merged
merged 24 commits into from
Apr 3, 2017
Merged

Add alias freewheel-ssp to stickyadstv bidder adapter #1043

merged 24 commits into from
Apr 3, 2017

Conversation

guillaume-sticky
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other

Description of change

As new may know StickyAdsTV is now FreeWheel (www.stickyads.tv)
So I've made changes to use the alias freewheel-ssp pointing to the stickyadstv bidder adaptor

  • test parameters for validating bids
{
  bidder: 'freewheel-ssp',
  params: {
      zoneId: 277225
  }
}

Other information

Test page: http://sandbox.stickyadstv.com/qa/prebid.html

We are using prebid to serve inbanner video ads and we are wondering if this case is concerned by the 20$ CPM CAP?
(http://prebid.org/dev-docs/show-video-with-a-dfp-video-tag.html#implement-custom-price-buckets-to-work-around-the-default-cpm-cap-of-20)

When I run tests using a price over 20$ everything seems fine.

If we need to work around this, can we do it from inside the bidder adapter or is the "custom price bucket" something the publisher needs to setup?

guillaume-sticky added 23 commits January 5, 2017 10:21
add stickyadsTV bidder adapter
632c8c1
init unit test file
a91ac2d
ad some unit tests
9e2d70e
fix unit test on ad format with parameters
9c92c3e
add some unit tests
7ed68e9
add unit tests on getBid method
88a45ac
add some test cases in unit tests
7d6bf3c
minor fix on component id tag.
affdd67
remove adapters-sticky.json test file
654a473
Merge remote-tracking branch 'Prebid/master'
3b0760e
use top most accessible window instead of window.top
8c0f143
Pass in the bid request in the createBid call.
fd877dc
use top most accessible window instead of window.top
09f7348
Merge remote-tracking branch 'Prebid/master'
28a36a6
add unit tests
90264e8
update unit tests
29453af
fix unit test.
b664ee1
fix CI build
57c31a1
Merge remote-tracking branch 'Prebid/master'
2915576
Merge remote-tracking branch 'Prebid/master'
c5c41be
add alias freewheel-ssp
475eee3
Merge remote-tracking branch 'Prebid/master'
71bfaa1
update unit tests on bidderCode value
410ee00
@mkendall07
Copy link
Member

LGTM.

@matthewlane matthewlane merged commit b61e01a into prebid:master Apr 3, 2017
outoftime added a commit to Genius/Prebid.js that referenced this pull request Apr 19, 2017
@outoftime
Merge branch 'master' of https://github.com/prebid/Prebid.js into pre…
b930704 
…built

* 'master' of https://github.com/prebid/Prebid.js: (38 commits)
  Add optional domain parameter to AdButler adapter (prebid#1078)
  Send transactionID to Criteo Services (prebid#1113)
  Fix `buildMasterVideoTagFromAdserverTag()` not selecting winning bid (prebid#1106)
  Remove placement size selection and filtering (prebid#1107)
  revert `srcdoc` change (prebid#1130)
  Add new Adapter- Beachfront Media (prebid#1062)
  Fixes SpringServe adapter (prebid#1101)
  Update Widespace request param (prebid#1098)
  - New Adapter: Innity (prebid#1074)
  Update Roxot prebid analytic adapter (prebid#1034)
  Yarn Package Manager (prebid#1109)
  allow writing into current document if prebid is loaded inside an iframe (prebid#1066)
  Adapter bug fix (prebid#1096)
  fix typo
  added pr review process and governance model (prebid#1103)
  added support for sampling in ga and base adapter, fixed up some tests (prebid#1011)
  Add Inneractive adapter (prebid#1048)
  Add alias freewheel-ssp to stickyadstv bidder adapter  (prebid#1043)
  Add Facebook Audience Network adapter (prebid#1068)
  Add Atomx support (prebid#1056)
  ...
vzhukovsky added a commit to aol/Prebid.js that referenced this pull request May 19, 2017
@vzhukovsky
Merge pull request prebid#90 in AOLP_ADS_JS/prebid.js from release/1.…
8b44d83 
…19.0 to aolgithub-master

* commit '5109273bd4317535b23e26ff609345101a3d038d': (49 commits)
  Disable unit tests that fails on PhantomJs.
  Fixed unit tests for adapter loader.
  Changed way of including analytic adapters.
  Added adapters in aolPartnersIds.json.
  Added changelog entry.
  Replace removed utils.extend functionality by object.assign.
  Add Inneractive adapter (prebid#1048)
  Add alias freewheel-ssp to stickyadstv bidder adapter  (prebid#1043)
  Add Facebook Audience Network adapter (prebid#1068)
  Add Atomx support (prebid#1056)
  Updated rubicon video bid endpoint in source and test files (prebid#1097)
  Pass through params to server (prebid#1084)
  Reset the list of slots to be requested between each action for pubmatic (prebid#1079)
  Support for downloading Analytics Adapters via http://prebid.org/download.html (prebid#1021)
  update PR template to include link to dev docs page (prebid#1075)
  Prebid 0.21.0
  Lifestreet adapter: ignore unnecessary events from creative. (prebid#1054)
  Video header bidding support to RhythmOne bidder adapter (prebid#1052)
  Add rubicon targeting to rubicon bid responses for bidderSettings use (prebid#1045)
  Fix adapter getSize (prebid#1064)
  ...
vzhukovsky added a commit to aol/Prebid.js that referenced this pull request May 22, 2017
@vzhukovsky
Merge pull request prebid#91 in AOLP_ADS_JS/prebid.js from release/1.…
ab3f32e 
…19.0 to master

* commit '5109273bd4317535b23e26ff609345101a3d038d': (49 commits)
  Disable unit tests that fails on PhantomJs.
  Fixed unit tests for adapter loader.
  Changed way of including analytic adapters.
  Added adapters in aolPartnersIds.json.
  Added changelog entry.
  Replace removed utils.extend functionality by object.assign.
  Add Inneractive adapter (prebid#1048)
  Add alias freewheel-ssp to stickyadstv bidder adapter  (prebid#1043)
  Add Facebook Audience Network adapter (prebid#1068)
  Add Atomx support (prebid#1056)
  Updated rubicon video bid endpoint in source and test files (prebid#1097)
  Pass through params to server (prebid#1084)
  Reset the list of slots to be requested between each action for pubmatic (prebid#1079)
  Support for downloading Analytics Adapters via http://prebid.org/download.html (prebid#1021)
  update PR template to include link to dev docs page (prebid#1075)
  Prebid 0.21.0
  Lifestreet adapter: ignore unnecessary events from creative. (prebid#1054)
  Video header bidding support to RhythmOne bidder adapter (prebid#1052)
  Add rubicon targeting to rubicon bid responses for bidderSettings use (prebid#1045)
  Fix adapter getSize (prebid#1064)
  ...
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
@dluxemburg
Add alias freewheel-ssp to stickyadstv bidder adapter (prebid#1043)
6817ddb 
* add stickyadsTV bidder adapter

* init unit test file

* ad some unit tests

* fix unit test on ad format with parameters

* add some unit tests

* add unit tests on getBid method

* add some test cases in unit tests

* minor fix on component id tag.

* remove adapters-sticky.json test file

* use top most accessible window instead of window.top

* Pass in the bid request in the createBid call.

* use top most accessible window instead of window.top

* add unit tests

* update unit tests

* fix unit test.

* fix CI build

* add alias freewheel-ssp

* update unit tests on bidderCode value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewlane matthewlane matthewlane approved these changes

Assignees

@matthewlane matthewlane

Labels
LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@guillaume-sticky @mkendall07 @matthewlane @jaiminpanchal27