Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sizeConfig[Conditional Ad Units] does not work when s2sConfig is enabled. #2315

Closed
mercuryyy opened this issue Mar 23, 2018 · 3 comments
Closed

sizeConfig[Conditional Ad Units] does not work when s2sConfig is enabled. #2315

mercuryyy opened this issue Mar 23, 2018 · 3 comments
Assignees
@jsnellbaker
Labels
bug

Comments

@mercuryyy
Copy link
Contributor

mercuryyy commented Mar 23, 2018 •
edited
Loading

trying to set sizeConfig from this doc for 1.7 prebid http://prebid.org/dev-docs/conditional-ad-units.html

When using the new sizeConfig[Conditional Ad Units] the adunits for the s2s are null and for bidders not in s2s it send them correctly.

I tested few configuration and when sizeConfig is enabled with the new Conditional Ad Units it does not send the ad units to s2s bidders.

once i remove the bidders from s2sConfig everything fires correctly.
@mercuryyy mercuryyy changed the title sizeConfig does not work when s2sConfig is enabled. sizeConfig[Conditional Ad Units] does not work when s2sConfig is enabled. Mar 23, 2018
@mercuryyy mercuryyy mentioned this issue Mar 24, 2018
Closed
@bretg bretg added the bug label Mar 26, 2018
@mkendall07
Copy link
Member

@mercuryyy
do you have an example page?

@mercuryyy
Copy link
Contributor Author

@mkendall07 i used this pull and it fixes some of the issues - https://github.com/javipm/Prebid.js

Any configuration you put in with sizeconfig and then enable a bidder in s2s it wont send the bids to the s2s adapter

@jsnellbaker jsnellbaker self-assigned this Mar 30, 2018
jsnellbaker added a commit that referenced this issue Apr 2, 2018
@jsnellbaker
initial commit to fix issue #2315
cf91b2d
@jsnellbaker jsnellbaker mentioned this issue Apr 2, 2018
Merged
1 task
mkendall07 pushed a commit that referenced this issue Apr 3, 2018
@jsnellbaker @mkendall07
fix issue #2315 sizeMapping not working with s2s requests (#2332)
749e3c4 
* initial commit to fix issue #2315

* moved transformHeightWidth function to prebidServerBidAdapter
@jsnellbaker
Copy link
Collaborator

@mercuryyy This should be fixed now in 1.7 release. If you continue to see any issues, please let us know.

dluxemburg pushed a commit to Genius/Prebid.js that referenced this issue Jul 17, 2018
@jsnellbaker @dluxemburg
fix issue prebid#2315 sizeMapping not working with s2s requests (preb…
1baf861 
…id#2332)

* initial commit to fix issue prebid#2315

* moved transformHeightWidth function to prebidServerBidAdapter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsnellbaker jsnellbaker

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mkendall07 @bretg @mercuryyy @jsnellbaker