Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uuid is undefined in prebid cache #2253

Closed
Roffray opened this issue Mar 12, 2018 · 3 comments · Fixed by #2260
Closed

uuid is undefined in prebid cache #2253

Roffray opened this issue Mar 12, 2018 · 3 comments · Fixed by #2260

Comments

@Roffray
Copy link
Contributor

Roffray commented Mar 12, 2018

Type of issue

Question

Description

I've taken the videojs demo page from the documentation to test our own adapter (vuble).
The problem is, when the adapter sends back an ad for DFP to play, the uuid in prebid url cache is "undefined" : https://prebid.adnxs.com/pbc/v1/cache?uuid=undefined because the hb_uuid sent to DFP is undefined too.

Steps to reproduce

Go in this link : http://demo.vuble.tv/headerbidding/videojs.vuble.html?pbjs_debug=true wich is setup to call our adapter.

Test page

http://demo.vuble.tv/headerbidding/videojs.vuble.html?pbjs_debug=true

Expected results

Whenever the adapter sends back an to play, we should be able to get DFP to get the vast from prebid cache.

Actual results

The hb_uuid sent to DFP is undefined, therefore the prebid cache url set up in DFP is not able to get the vast.

Platform details

I'm testing on Chrome 65.0.3325.146, with the latest prebid version (created with gulp serve).

Am I doing anything wrong or missing anything here ?

Thank you,
Geoffray

@Roffray Roffray changed the title uuid is undefiend in prebid cache uuid is undefined in prebid cache Mar 12, 2018
@Roffray
Copy link
Contributor Author

Roffray commented Mar 13, 2018

You'll have the same issue here with this time the appnexus bidder : http://demo.vuble.tv/headerbidding/videojs.html.

Geoffray

@matthewlane
Copy link
Collaborator

Hi @Roffray, for the second example page with the appnexus bidder, you should be able to get a uuid by setting

pbjs.setConfig({ 
  cache: { url: 'https://prebid.adnxs.com/pbc/v1/cache' },
});

and for vuble, it looks like a uuid isn't getting set because the vuble bid response object doesn't contain a mediaType field set to 'video' (docs link). If you add that locally and it works out please submit a PR and we'll merge it

@Roffray
Copy link
Contributor Author

Roffray commented Mar 13, 2018

Thank you for your answer :)

Here is the PR : #2253

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants