Skip to content

Commit

Permalink
LiveIntent Id Submodule: Update live-connect build dependency to 2.3.1 (
Browse files Browse the repository at this point in the history
#8198)

* Update live-connect to 2.3.1

* Fix tests

* Update release version

Co-authored-by: Viktor Dreiling <viktor@Viktors-MBP.fritz.box>
Co-authored-by: Viktor Dreiling <viktor@Viktors-MacBook-Pro.fritz.box>
Co-authored-by: Viktor Dreiling <viktor@Viktors-MBP.localdomain>
  • Loading branch information
4 people authored Apr 2, 2022
1 parent 02ea759 commit 4a83fff
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 13 deletions.
17 changes: 9 additions & 8 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@
"express": "^4.15.4",
"fun-hooks": "^0.9.9",
"just-clone": "^1.0.2",
"live-connect-js": "2.0.0"
"live-connect-js": "2.3.1"
},
"optionalDependencies": {
"fsevents": "^2.3.2"
Expand Down
8 changes: 4 additions & 4 deletions test/spec/modules/liveIntentIdSystem_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ describe('LiveIntentId', function() {
consentString: 'consentDataString'
})
liveIntentIdSubmodule.getId(defaultConfigParams);
expect(server.requests[0].url).to.match(/https:\/\/rp.liadm.com\/j\?wpn=prebid.*us_privacy=1YNY.*&gdpr=1&gdpr_consent=consentDataString.*/);
expect(server.requests[0].url).to.match(/https:\/\/rp.liadm.com\/j\?.*&us_privacy=1YNY.*&wpn=prebid.*&gdpr=1&gdpr_consent=consentDataString.*/);
});

it('should fire an event when getId and a hash is provided', function() {
Expand All @@ -88,7 +88,7 @@ describe('LiveIntentId', function() {
}
}
}});
expect(server.requests[0].url).to.match(/https:\/\/collector.liveintent.com\/j\?aid=a-0001&wpn=prebid.*/);
expect(server.requests[0].url).to.match(/https:\/\/collector.liveintent.com\/j\?.*aid=a-0001.*&wpn=prebid.*/);
});

it('should initialize LiveConnect and emit an event with a privacy string when decode', function() {
Expand Down Expand Up @@ -195,7 +195,7 @@ describe('LiveIntentId', function() {

it('should include the LiveConnect identifier when calling the LiveIntent Identity Exchange endpoint', function() {
const oldCookie = 'a-xxxx--123e4567-e89b-12d3-a456-426655440000'
getDataFromLocalStorageStub.withArgs('_li_duid').returns(oldCookie);
getCookieStub.withArgs('_lc2_fpi').returns(oldCookie)
let callBackSpy = sinon.spy();
let submoduleCallback = liveIntentIdSubmodule.getId(defaultConfigParams).callback;
submoduleCallback(callBackSpy);
Expand All @@ -211,7 +211,7 @@ describe('LiveIntentId', function() {

it('should include the LiveConnect identifier and additional Identifiers to resolve', function() {
const oldCookie = 'a-xxxx--123e4567-e89b-12d3-a456-426655440000'
getDataFromLocalStorageStub.withArgs('_li_duid').returns(oldCookie);
getCookieStub.withArgs('_lc2_fpi').returns(oldCookie);
getDataFromLocalStorageStub.withArgs('_thirdPC').returns('third-pc');
const configParams = { params: {
...defaultConfigParams.params,
Expand Down

0 comments on commit 4a83fff

Please sign in to comment.