Skip to content

Commit

Permalink
SublimeBidAdapter src/url.js import fix (#5150)
Browse files Browse the repository at this point in the history
* added support for pubcommon, digitrust, id5id

* added support for IdentityLink

* changed the source for id5

* added unit test cases

* changed source param for identityLink

* avoid using src/url.js

* avoid using for..of
  • Loading branch information
pm-harshad-mane authored Apr 21, 2020
1 parent f85862d commit 1e1a720
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
3 changes: 1 addition & 2 deletions modules/sublimeBidAdapter.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { registerBidder } from '../src/adapters/bidderFactory.js';
import { config } from '../src/config.js';
import * as utils from '../src/utils.js';
import * as url from '../src/url.js';

const BIDDER_CODE = 'sublime';
const BIDDER_GVLID = 114;
Expand Down Expand Up @@ -55,7 +54,7 @@ export function sendEvent(eventName) {

log('Sending pixel for event: ' + eventName, eventObject);

const queryString = url.formatQS(eventObject);
const queryString = utils.formatQS(eventObject);
utils.triggerPixel('https://' + SUBLIME_ANTENNA + '/?' + queryString);
}

Expand Down
3 changes: 2 additions & 1 deletion test/spec/modules/colossussspBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,8 @@ describe('ColossussspAdapter', function () {
expect(placement).to.have.property('eids')
expect(placement.eids).to.be.an('array')
expect(placement.eids.length).to.be.equal(4)
for (let v of placement.eids) {
for (let index in placement.eids) {
let v = placement.eids[index];
expect(v).to.have.all.keys('source', 'uids')
expect(v.source).to.be.oneOf(['britepool.com', 'identityLink', 'adserver.org', 'id5-sync.com'])
expect(v.uids).to.be.an('array');
Expand Down

0 comments on commit 1e1a720

Please sign in to comment.