Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct & simplify component name detection (Fixes #44) #45

Merged
merged 2 commits into from
Sep 15, 2017

Conversation

developit
Copy link
Member

@developit developit commented Sep 8, 2017

The logic was really just incorrect, displayName and name will only ever exist on a component's constructor, not the prototype or instance.

Copy link

@sampi sampi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@developit developit merged commit 6ce1519 into master Sep 15, 2017
@developit developit deleted the component-name-fix branch September 15, 2017 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants