Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Serialize defaultChecked & defaultSelected #224

Merged
merged 3 commits into from
Jul 8, 2022
Merged

fix: Serialize defaultChecked & defaultSelected #224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4127295
fix: Serialize defaultChecked as checked attr
rschristian Jun 16, 2022
b340af4
docs: Adding changeset
rschristian Jun 16, 2022
d4e2386
fix: Serialize defaultSelected as selected attr
rschristian Jul 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/cyan-students-unite.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'preact-render-to-string': patch
---

Ensures `defaultChecked` is serialized as `checked` attribute
9 changes: 7 additions & 2 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ const SHALLOW = { shallow: true };
// components without names, kept as a hash for later comparison to return consistent UnnamedComponentXX names.
const UNNAMED = [];

const VOID_ELEMENTS = /^(area|base|br|col|embed|hr|img|input|link|meta|param|source|track|wbr)$/;
const VOID_ELEMENTS =
/^(area|base|br|col|embed|hr|img|input|link|meta|param|source|track|wbr)$/;

const UNSAFE_NAME = /[\s\n\\/='"\0<>]/;

Expand Down Expand Up @@ -263,10 +264,14 @@ function _renderToString(vnode, context, opts, inner, isSvgMode, selectValue) {

if (name === 'defaultValue') {
name = 'value';
} else if (name === 'defaultChecked') {
name = 'checked';
} else if (name === 'defaultSelected') {
name = 'selected';
} else if (name === 'className') {
if (typeof props.class !== 'undefined') continue;
name = 'class';
} else if (isSvgMode && name.match(/^xlink:?./)) {
} else if (isSvgMode && /^xlink:?./.test(name)) {
Comment on lines -269 to +274
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated (sorry!) but .test() should be marginally faster.

name = name.toLowerCase().replace(/^xlink:?/, 'xlink:');
}

Expand Down
14 changes: 14 additions & 0 deletions test/render.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,20 @@ describe('render', () => {
expect(rendered).to.equal(expected);
});

it('should serialize defaultChecked prop to the checked attribute', () => {
let rendered = render(<input type="checkbox" defaultChecked />),
expected = `<input type="checkbox" checked />`;

expect(rendered).to.equal(expected);
});

it('should serialize defaultSelected prop to the selected attribute', () => {
let rendered = render(<option defaultSelected />),
expected = `<option selected></option>`;

expect(rendered).to.equal(expected);
});

it('should include boolean aria-* attributes', () => {
let rendered = render(<div aria-hidden aria-whatever={false} />),
expected = `<div aria-hidden="true" aria-whatever="false"></div>`;
Expand Down