-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for disabling PageScaling in supported PDF Clients #448
Conversation
👍 |
This needs documentation in order to be merged, but otherwise looks fine. Please re-open when it is documented, and I'll merge it. |
PrintScaling(Optional; PDF 1.6) The page scaling option to be selected when a print dialog is displayed for this document. Valid values are
|
* Remove RDoc task now that we're using YARD * Make gemfile read from gemspec for dependencies
Colspan fixes
If this is a feature that is only in PDF 1.6+, I think we'd need a min_version guard in this code. Is that correct @bradediger? |
@sandal Correct. We'd need a |
Okay... so this patch needs a few things then, IMO.
Does someone want to take this up? If you've already got commit access, pushing this code to a branch on prawnpdf and then opening a fresh pull request is the way to go. |
I'm closing this out again, but will reopen if someone volunteers to work on the above feedback points. |
Hey @sandal, I have fixed the following:
I pushed the changes to my fork but I'm quite new to github so I have no clue what to do next. Please advise :) |
What you did looks OK to me. I will probably rebase down to a single commit before merging, but I think I can take it from here. Thanks! |
This is #448, just squashed down into a single commit.
Merged, thank you! You've also been given commit access to Prawn. Please see this page for contribution guidelines: |
Most PDF clients automatically scales a document if it feels that the document won't fit within the page margins. However, some clients (such as the PDF client in iOS) does not give the user a possibility to disable the print scaling.
This commit adds support to Prawn for disabling print_scaling by supplying the option :print_scaling => :none