fix: Market Activity report particulary parsed #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pratik141
approved these changes
May 16, 2024
| response = fetch_csv(url, cookies, response_type="raw") | ||
| df = pd.read_csv(BytesIO(response), skiprows=8) | ||
| df.drop(columns=['Unnamed: 0'], inplace=True) | ||
| df = df[:77] |
There was a problem hiding this comment.
@shivam2502 Hey, this screws the top gainer/loser when you slice, please can you get rid of it. Thanks.
|
Nope,
it is parsing the relevant part from the report. We will get top gainers
and losers from it.
…On Fri, 17 May 2024 at 15:12, Jitendra Varma ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In nsedt/reports.py
<#55 (comment)>:
> @@ -35,8 +39,11 @@ def get_market_activity_report(date: str):
cookies = get_cookies()
url = f"{REPORT_URL}{MARKET_ACTIVITY_REPORT}{date}.csv"
- return fetch_csv(url, cookies, response_type="raw")
-
+ response = fetch_csv(url, cookies, response_type="raw")
+ df = pd.read_csv(BytesIO(response), skiprows=8)
+ df.drop(columns=['Unnamed: 0'], inplace=True)
+ df = df[:77]
@shivam2502 <https://github.com/shivam2502> Hey, this screws the top
gainer/loser when you slice, please can you get rid of it. Thanks.
—
Reply to this email directly, view it on GitHub
<#55 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJQXTF47SDA6TKPZBY7LIR3ZCXGH3AVCNFSM6AAAAABHS6DXKCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANRSHAZDKOBYGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the data from function get_market_activity_report in reports.py was
- Unorganized
- Bytes format
- Contained irrelevant headers and metadata
- Not Convertible to dataframe
Now this function returns
- Dataframe with only relevant data